Grid

278 - frame lockups

What version of Grid are you using?
r1278 currently, but tried alot of versions

What version (and language) of WoW are you using?
3.3 en

What were you doing when the problem occured?
anything

What happened?  What did you expect to happen instead?
It was a ticket about frame locks before but was closed because you couldnt reproduce it. It happens on every group change (someone is changing zone, joining or leaving group). It's very hard to play in large groups (IoC, AV), even in 25 man raids it is annoying.

Do you have an error log of what happened?
no

Please provide any additional information below.
The reason i'm posting this ticked again is that i found something new. It happens only when i use an opengl engine (wow.exe -opengl). May be the grid is using something to update the frame which is buggy in opengl implementation. Although Grid2 is not affected, it's working smooth, but not really usable for me.

Name Description Size MD5
small_patch.zip without logic changes 9.9 KiB ca9e90f34d4e...
User When Change
Phanx Oct 13, 2010 at 12:32 UTC Changed status from Accepted to Fixed
triamazikamno Oct 13, 2010 at 11:45 UTC

Deleted attachment grid_lockups_patch_v7b.zip: obsolete

triamazikamno Sep 29, 2010 at 10:10 UTC

Deleted attachment grid_lockups_patch_v7a.zip: obsolete

triamazikamno Sep 29, 2010 at 10:09 UTC

Deleted attachment grid_lockups_patch_v7.zip: broken

triamazikamno Sep 29, 2010 at 10:09 UTC

Deleted attachment grid_lockups_patch_v6.zip: broken

triamazikamno Sep 22, 2010 at 16:22 UTC

Added attachment small_patch.zip

triamazikamno Sep 20, 2010 at 03:19 UTC

Added attachment grid_lockups_patch_v7b.zip

triamazikamno Sep 17, 2010 at 22:02 UTC

Added attachment grid_lockups_patch_v7a.zip

triamazikamno Sep 16, 2010 at 10:43 UTC

Added attachment grid_lockups_patch_v7.zip

triamazikamno Sep 11, 2010 at 08:28 UTC

Deleted attachment grid_lockups_patch_v5.zip: broken

triamazikamno Sep 11, 2010 at 08:04 UTC

Added attachment grid_lockups_patch_v6.zip

triamazikamno Sep 11, 2010 at 08:04 UTC

Deleted attachment grip_lockups_patch_v6.zip: typo

triamazikamno Sep 11, 2010 at 08:03 UTC

Added attachment grip_lockups_patch_v6.zip

triamazikamno Sep 11, 2010 at 07:54 UTC

Deleted attachment grid_lockups_patch_v4.zip: broken

triamazikamno Sep 07, 2010 at 12:52 UTC

Deleted attachment grid_lockups_patch_v3.zip: broken

triamazikamno Sep 07, 2010 at 12:39 UTC

Added attachment grid_lockups_patch_v5.zip

triamazikamno Sep 07, 2010 at 04:38 UTC Changed description:
+ plain$What version of Grid are you using?
+ r1278 currently, but tried alot of versions
+
+ What version (and language) of WoW are you using?
+ 3.3 en
+
+ What were you doing when the problem occured?
+ anything
+
+ What happened?  What did you expect to happen instead?
+ It was a ticket about frame locks before but was closed because you couldnt reproduce it. It happens on every group change (someone is changing zone, joining or leaving group). It's very hard to play in large groups (IoC, AV), even in 25 man raids it is annoying.
+
+ Do you have an error log of what happened?
+ no
+
+ Please provide any additional information below.
+ The reason i'm posting this ticked again is that i found something new. It happens only when i use an opengl engine (wow.exe -opengl). May be the grid is using something to update the frame which is buggy in opengl implementation. Although Grid2 is not affected, it's working smooth, but not really usable for me.
triamazikamno Sep 07, 2010 at 04:38 UTC

Added attachment grid_lockups_patch_v4.zip

triamazikamno Sep 07, 2010 at 04:38 UTC

Deleted attachment grid_lockups_patch_v4.zip: typo

triamazikamno Sep 07, 2010 at 04:25 UTC

Added attachment grid_lockups_patch_v4.zip

triamazikamno Sep 06, 2010 at 17:58 UTC

Added attachment grid_lockups_patch_v3.zip

triamazikamno Sep 06, 2010 at 17:58 UTC

Deleted attachment grid_lockups_patch_v2.zip: broken

triamazikamno Sep 06, 2010 at 17:57 UTC

Deleted attachment grid_lockups_patch.zip: broken

triamazikamno Sep 05, 2010 at 08:01 UTC

Added attachment grid_lockups_patch_v2.zip

triamazikamno Sep 05, 2010 at 08:01 UTC

Deleted attachment grip_lockups_patch_v2.zip: typo

triamazikamno Sep 05, 2010 at 07:59 UTC

Added attachment grip_lockups_patch_v2.zip

Phanx Sep 01, 2010 at 04:47 UTC Changed status from Replied to Accepted
triamazikamno Aug 23, 2010 at 16:17 UTC

Added attachment grid_lockups_patch.zip

FallenLegionEU Aug 09, 2010 at 18:27 UTC Changed status from Waiting to Replied
Phanx Aug 08, 2010 at 23:14 UTC Changed status from Replied to Waiting
triamazikamno Feb 06, 2010 at 00:02 UTC Changed status from Waiting to Replied
Phanx Feb 05, 2010 at 23:10 UTC Changed status from Replied to Waiting
triamazikamno Feb 05, 2010 at 00:41 UTC Changed status from Waiting to Replied
Phanx Feb 05, 2010 at 00:11 UTC Changed status from Replied to Waiting
triamazikamno Feb 03, 2010 at 07:35 UTC Changed status from Waiting to Replied
Phanx Feb 02, 2010 at 23:40 UTC Changed assigned to from Pastamancer to Phanx
Phanx Feb 02, 2010 at 23:40 UTC Changed status from New to Waiting
triamazikamno Jan 30, 2010 at 20:30 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • Avatar of TomajRT TomajRT Jul 22, 2010 at 03:46 UTC - 0 likes

    Hi there, I know this is isitisit's ticket, but I have been having a similar issue, thought I might be able to provide a little bit extra information on this. In addition to people joining or leaving the group causing a brief lockup, it also happens when people enter or leave vehicles. It's far less noticeable in something small like Strand of the Ancients, but in a full Wintergrasp group or Isle of Conquest, it gets to be really frustrating, really fast. I think, in part, this is because Grid ends up with a new pet frame for the player and the vehicle (the "pet") becomes the player frame (feel free to correct me if I'm wrong, though).

  • Avatar of triamazikamno triamazikamno Feb 11, 2010 at 23:49 UTC - 0 likes

    Thanks, will wait :)

  • Avatar of Phanx Phanx Feb 11, 2010 at 23:27 UTC - 0 likes

    I haven't had time to investigate this further, but I did want to drop by and let you know I haven't forgotten about the issue, and will look into it as soon as I can.

  • Avatar of triamazikamno triamazikamno Feb 06, 2010 at 05:05 UTC - 0 likes

    Added self:Debug("123123123") on the line 1291 and noticed that when ppl are joining/leaving the group(larger group - more lags) i'm getting thousands of these messages for 1 person. So I checked every call of UpdateFrameUnits() in GridFrame.lua and ended up with commenting out it in the function GridFrame:RegisterFrame (line 1218) and the self:RegisterEvent("Grid_RosterUpdated", "UpdateFrameUnits") (line 1176)
    And now i still have freezes when ppl are joining/leaving the group, but ALOT less, much more playable.
    Any thoughts?

    Sorry for my bad english btw, I'm russian :)

    Last edited Feb 06, 2010 by triamazikamno
  • Avatar of triamazikamno triamazikamno Feb 06, 2010 at 01:01 UTC - 0 likes

    Experimented abit, tried to comment everything in that function and uncomment one by one and found that the only string
    local unitid = frame:GetModifiedUnit()
    is a reason of the freezes

  • Avatar of triamazikamno triamazikamno Feb 06, 2010 at 00:02 UTC - 0 likes

    No freezes with this

  • Avatar of Phanx Phanx Feb 05, 2010 at 23:10 UTC - 0 likes

    Alright, let's move back up the food chain, then. Open GridFrame.lua, find this:

    function GridFrame:UpdateFrameUnits()
    

    After it, on a new line, add:

    	do return end
    

    Does the problem still occur that way?

  • Avatar of triamazikamno triamazikamno Feb 05, 2010 at 00:41 UTC - 0 likes

    Yep, still occur

  • Avatar of Phanx Phanx Feb 05, 2010 at 00:11 UTC - 0 likes

    Well, the only thing that Grid does after that debug message is update all indicators on the frame. If you don't have any statuses enabled on any indicators, then almost no processing is being done. I still can't reproduce the problem, so you're going to have to try some things to help me narrow it down.

    Open GridFrame.lua and comment out line 1286 by adding two dashes at the beginning of it:

    						self:UpdateIndicators(frame)
    

    Save the file and reload your UI. Does the problem still occur?

  • Avatar of triamazikamno triamazikamno Feb 03, 2010 at 17:36 UTC - 0 likes

    Ok, i disabled every status, checked out every status in a Frame section. Still getting frame skipping.
    Enabled debug and noticed that every message like
    "[22:33](DEBUG) GridFrame:[22:33:43. 67] Updating GridLayoutHeader4UnitButton2 to raid16 0x05000000021DBD09 was raid15 0x050000000290D5A3" was followed by the freeze

Facts

Last updated
Mar 30, 2012
Reported
Jan 30, 2010
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
5

Reported by

Possible assignees