Grid

224 - Corner Icons - hidden behind - fix

I wasn't able to see the corner Icons of Grid. Even with a resettet profile.
So i decided to check what's wrong.
Finaly i found the function "GridFrameClass.prototype:CreateIndicator(indicator)" in GridFrame.lua in line 536.
I changed the parameter in line 548 of "f:SetFrameLevel(5)" from 5 to 10.
Now i see the cornericons again.

I tested every framelevel between 5 and 10.
At framelevel 9 the corner Icon were half transparent.
So i guess 10 is the best choice.

Here the full fixed function:

function GridFrameClass.prototype:CreateIndicator(indicator)
   local f = CreateFrame("Frame", nil, self.frame)

   f:SetWidth(GridFrame:GetCornerSize())
   f:SetHeight(GridFrame:GetCornerSize())
   f:SetBackdrop( {
		    bgFile = "Interface\\Addons\\Grid\\white16x16", tile = true, tileSize = 16,
		    edgeFile = "Interface\\Addons\\Grid\\white16x16", edgeSize = 1,
		    insets = {left = 1, right = 1, top = 1, bottom = 1},
		 })
   f:SetBackdropBorderColor(0,0,0,1)
   f:SetBackdropColor(1,1,1,1)
   f:SetFrameLevel(10)
   f:Hide()
   
   self.frame[indicator] = f
   
   self:PositionIndicator(indicator)
end
User When Change
Phanx Fri, 06 Nov 2009 06:50:12 Changed status from Replied to Invalid
Trockenbrot Thu, 05 Nov 2009 22:40:51 Changed status from Waiting to Replied
Phanx Thu, 05 Nov 2009 04:55:34 Changed assigned to from Pastamancer to Phanx
Phanx Thu, 05 Nov 2009 04:55:29 Changed status from New to Waiting
Trockenbrot Sun, 01 Nov 2009 09:13:24 Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of Phanx Phanx Fri, 06 Nov 2009 06:50:02

    If the problem is indeed caused by nUI, as I suspect it is, then it isn't Grid's responsibility to add code to fix it. Instead, it would be fairly simple for nUI to fix the problem; since nuI is already modifying the frame level/strata of some of Grid's components, why not just do it for all of them?

  • Avatar of Trockenbrot Trockenbrot Thu, 05 Nov 2009 22:40:48

    1. Yes i mean the small squares in the corners. I got the SideIcons-addon, too. This one had the same problem. And is fixed with the same framelevel modification.

    2. I'm using nUi, yes. So this might be the "problem". If more nUi users got the same problem, then maybe it's n idea of adding a framelevel-slider to the config of Grid. Just for a "better" compatibility with such Addons like nUi ;-) Just an idea.

    Thanks for your answer!

  • Avatar of Phanx Phanx Thu, 05 Nov 2009 04:55:24

    1. Grid does not provide "corner icons". Do you mean the colored squares, or do you mean a third-party plugin that creates actual icons in the corners? If you're talking about a plugin, Grid is not responsible for its functionality, and you should report the problem to the plugin's author.

    2. I've been using Grid for a long time, and I've never seen any problems with layering. Have you made other modifications to Grid that affect the frame level or frame strata of other Grid elements? Do you use any third-party addons that affect the level/strata, such as nUI or other premade panel-type interfaces that claim to integrate with Grid? If the answer to either of those questions is yes, then it isn't appropriate for the public distribution of Grid to be changed to support your private modifications and/or your use of a third-party addon. If the answer is "no" to both, please verify that the problem occurs after performing the following:

    • Delete your copy of Grid and reinstall it from a fresh download.
    • Delete your saved variables file for Grid.
    • Log in with all addons disabled except for Grid (plugins for Grid are not Grid itself, and should be disabled during testing).
  • 3 comments

Facts

Last updated on
06 Nov 2009
Reported on
01 Nov 2009
Status
Invalid - This was not a valid report.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.

Reported by

Possible assignees