Grid

151 - Wintergrasp layout functionality

Currently Wintergrasp raids are treated as regular or heroic raids, depending on what the raid leader has set up.  Seeing as they default to 10/25 players, while BGs default to 40, I figure (and I prefer) it if raids inside the zone wintergrasp are treated as 40man raids.

This does however cause raid groups forming in Wintergrasp for VoA to show up as 40mans, until they zone inside VoA.  I'm not sure if there's a good way around this, but for me at least, this method is preferred.

I've attached the patch file for my changes.

Name Size MD5
wintergrasp-layout.patch 693 B f9394ad35a38...
wintergrasp-layout.patch 697 B 1ca89c12aec6...
User When Change
Phanx Nov 10, 2009 at 10:32 UTC Changed status from Accepted to Fixed
Phanx Oct 27, 2009 at 07:15 UTC Changed status from New to Accepted
Phanx Oct 27, 2009 at 07:15 UTC Changed assigned to from Pastamancer to Phanx
enigmacurse Jun 19, 2009 at 03:24 UTC

Added attachment wintergrasp-layout.patch

enigmacurse Jun 19, 2009 at 02:34 UTC

Added attachment wintergrasp-layout.patch

enigmacurse Jun 19, 2009 at 02:33 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 6 comments
  • Avatar of Greltok Greltok Nov 10, 2009 at 02:44 UTC - 0 likes

    Addressed in r1232.

  • Avatar of Phanx Phanx Oct 27, 2009 at 07:15 UTC - 0 likes

    Hmm, I could have sworn Grid already gave Wintergrasp special treatment to use the Battleground layout. Anyway, your patch only performs a check when the group makeup changes, not when changing zones, so it isn't suitable for release as-is. Grid2's approach may be best. Consider the issue accepted though. I'll do something with it.

  • Avatar of Greltok Greltok Jun 19, 2009 at 05:44 UTC - 0 likes

    Alternately could use the same approach Grid 2 does. If you're outside, and the raid has more than 25, treat it as a BG.

    http://paste.wowace.com/797/

  • Avatar of enigmacurse enigmacurse Jun 19, 2009 at 03:27 UTC - 0 likes

    Can't work out how to remove old attachments, so use the one with MD5 starting with 1ca89

  • Avatar of enigmacurse enigmacurse Jun 19, 2009 at 03:24 UTC - 0 likes

    Ok adding new patch, using LibBabble-Zone-3.0, not sure if that's included in Grid atm though, it's from another of my Ace addons.

  • Avatar of enigmacurse enigmacurse Jun 19, 2009 at 03:10 UTC - 0 likes

    Just realised, my patch is broken, the localisation isn't working. Will try to fix after this WG :)

  • 6 comments

Facts

Last updated
Nov 10, 2009
Reported
Jun 19, 2009
Status
Fixed - Developer made requested changes. QA should verify.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees