Grid

138 - Better view for overheal

Hi,

I send you my own patch to have a better view for incoming heal/overheal.
With this patch when you'll do an overheal of 1k for a spell 4k instead of "+4k" in green you'll see "+1k" in red, you can custom the color in the gui.

Then, you can also check the "percent" toggle to see the percentage of overheal insted of the value, then in the previous example you'll see "25%"

I've do some little modification in :
function GridStatusHeals:FormatIncomingText
function GridStatusHeals:SendIncomingHealsStatus
function GridStatusHeals:UpdateIncomingHeals

I would be happy if you add this patch :)

Name Size MD5
GridLocale-enUS.lua 10.7 KiB 802ae87cdfe0...
GridLocale-frFR.lua 17.1 KiB 1d549f900b13...
GridStatusHealth.lua 9.5 KiB fd4433b1aa40...
User When Change
Phanx Oct 31, 2009 at 07:45 UTC Changed status from Replied to Declined
jmlane1987 Oct 27, 2009 at 20:32 UTC Changed status from Waiting to Replied
Phanx Oct 27, 2009 at 12:30 UTC Changed status from New to Waiting
namxo May 30, 2009 at 18:47 UTC

Added attachment GridStatusHealth.lua

namxo May 30, 2009 at 18:46 UTC

Added attachment GridLocale-frFR.lua

namxo May 30, 2009 at 18:46 UTC

Added attachment GridLocale-enUS.lua

namxo May 30, 2009 at 18:46 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of Phanx Phanx Oct 31, 2009 at 07:45 UTC - 0 likes

    Yeah, it would be fairly simple to write a status that essentially replaced the "Incoming Heals" status; call it "Detailed Incoming Heals" or something, and it could work however you want, and you'd just disable the basic "Incoming Heals" entirely. Most of it would probably just be a copy-and-paste from GridStatusHeals.lua.

  • Avatar of jmlane1987 jmlane1987 Oct 27, 2009 at 20:32 UTC - 0 likes

    I see your point, Phanx, and you raise a very valid point. I don't actually think I would ever use this. I don't think having the option to see over-healing in some form of indicator is completely useless however. Perhaps this functionality doesn't belong in Grid itself, but at the very least, Namxo, you should release your own Grid-dependent addon (read: module) to add this functionality, if you still would like to have the option. That way your work won't go to waste.

  • Avatar of Phanx Phanx Oct 27, 2009 at 07:31 UTC - 0 likes

    "+3k (+1k)" wouldn't work for the majority of users due to space constraints. Adding an option to switch the text value of the Incoming heals status from "incoming heals" to "incoming overheals" would be possible, but I'm not sure I see the point. Consider:

    If someone is missing 3k health, does it really matter if the heal someone else is casting is on them is +3k or +4k healing? If the answer is "no", then you don't need to know.

    If someone is missing 3k health, and you start casting a heal on them, are you really going to stop your heal and cast a smaller one if you see that the estimated value of your heal is +4k instead of +3k? If the answer is "no", then you don't need to know.

    If your answer to either of those questions if "yes", I'd be curious to know what you're doing where you have time to cancel heals mid-cast when you see an estimate that indicates you might be healing for 25% too much, and where your tanks and other group members can afford to wait for you to stop and cast a different spell just to save yourself 100 mana. If the information won't affect what you do, why do you need the information?

    Last edited Oct 27, 2009 by Phanx
  • Avatar of CMTitan CMTitan Oct 26, 2009 at 18:05 UTC - 0 likes

    Another possibility is to allow overheal to be given using an option for the incoming heal status:

    Show Overheal: Shows incoming heals as +Effective Heal (+Overheal) when the heal would overheal.

    So, for example, healing 4k with a deficit of only 3k would show as "+3k (+1k)". I'm not sure if it's doable considering the space. It would keep the current behaviour (effective heal, if I'm not mistaken) and would add the overhealing part as an option.

  • Avatar of jmlane1987 jmlane1987 Oct 26, 2009 at 17:03 UTC - 0 likes

    I think it might be more beneficial to add this as a new status called "overheal" instead of overriding the default behaviour of the incoming heal status. That way people who are happy with the current solution can keep their setup without it breaking unexpectedly, and people who want to take advantage of your "overheal" status can add it to their frames accordingly.

    If I get some time, I may make this change and upload a new patch.

  • 5 comments

Facts

Last updated
Mar 30, 2012
Reported
May 30, 2009
Status
Declined - We decided not to take action on this ticket.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees