GnomeWorks TradeSkill Frame

427 - Queue doesn't update when crafting materials are collected from the bank

Potential bug fix for:
The Queue window does not update correctly when crafting materials are collected from the bank.

Example:  
In the main window click QUEUE to craft an item that has materials in the bank.  
Minor Glyph of Porcupine is selected and QUEUE is clicked.
The Queue window shows there are 10 Stranglekelp in the bank.
Go to then bank, talk to the teller and open the bank bags.
Click on the Queue window Reagent line "bank" -or- reagent line "Stranglekelp" and the materials are collected from the bank into your inventory bags.
The Reagent window will incorrectly show
       Vendor
3     Midnight Ink
       Missing
3     Ink of Dreams.

The workaround was to clear the queue then requeue the Glyph with the materials in inventory.  It would progress to the next step of milling the herbs.

*** Here is a potential fix that needs verified:  ***

Queue.lua line 318
Comment out "Return 0"
from
            if not reagentsChanged then
                AddItemsToShoppingList(player, entry)
                Return 0
            end
to
            if not reagentsChanged then
                AddItemsToShoppingList(player, entry)
--              Return 0
            end

Now when materials are collected from the bank the Queue window correctly updates to
[Process Mill Stranglekelp x 2]
 
I haven't noticed any new bugs yet so please verify with testing.

User When Change
WildCard_25 Oct 16, 2012 at 08:19 UTC
Gwizzz Sep 17, 2012 at 00:04 UTC Changed description:
- What is the nature of the defect?
+ Potential bug fix for:
  The Queue window does not update correctly when crafting materials are collected from the bank.
+ Example:
- What (if anything) triggers the defect?  (happens when loading, when activating the mod, when clicking a particular button, etc)
- Collecting materials from the bank does not update the Queue window to progress to the next step in the crafting process.
-
  In the main window click QUEUE to craft an item that has materials in the bank.
- Example:  QUEUE Minor Glyph of Porcupine.  Queue window shows there are 10 Stranglekelp in the bank.
+ Minor Glyph of Porcupine is selected and QUEUE is clicked.
+ The Queue window shows there are 10 Stranglekelp in the bank.
  Go to then bank, talk to the teller and open the bank bags.
  Click on the Queue window Reagent line "bank" -or- reagent line "Stranglekelp" and the materials are collected from the bank into your inventory bags.
- The Reagent window now incorrectly shows
+ The Reagent window will incorrectly show
         Vendor
  3     Midnight Ink
         Missing
  3     Ink of Dreams.
  The workaround was to clear the queue then requeue the Glyph with the materials in inventory.  It would progress to the next step of milling the herbs.

- *** Potential fix that needs verified:  ***
+ *** Here is a potential fix that needs verified:  ***
  Queue.lua line 318
  Comment out "Return 0"
Gwizzz Sep 11, 2012 at 22:22 UTC Changed description type from BBCode to Plain Text

Changed description:
  *** Potential fix that needs verified:  ***

  Queue.lua line 318
- Remove or Comment out "Return 0"
+ Comment out "Return 0"
  from
  			if not reagentsChanged then
  				AddItemsToShoppingList(player, entry)
----------------------------------------
  to
  			if not reagentsChanged then
  				AddItemsToShoppingList(player, entry)
+ --              Return 0
  			end

  Now when materials are collected from the bank the Queue window correctly updates to
Gwizzz Sep 11, 2012 at 22:16 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of lilsparky lilsparky Oct 03, 2012 at 00:06 UTC - 0 likes

    yeah, i'm not surprised this breaks something else...

    i've tried to make the queue not recalculate too frequently, but still present up to date information. it could be that it doesn't recalculate properly after collecting the bank items. possible tests would be to do other manipulations to the queue adding items, adjust counts, selecting different sources. see if any of those result in proper recalculation.

  • Avatar of remcoros remcoros Oct 02, 2012 at 21:14 UTC - 0 likes

    @remcoros: Go

    I reverted this fix because it breaks reagent calculation logic.

    I am going to have another look at this issue.

  • Avatar of remcoros remcoros Sep 30, 2012 at 17:53 UTC - 0 likes

    fixed in r190

  • Avatar of yunohu yunohu Sep 13, 2012 at 23:06 UTC - 0 likes

    I applied this patch, so far all good, and it works great with grabbing stuff from the bank

  • 4 comments

Facts

Last updated
Oct 16, 2012
Reported
Sep 11, 2012
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees