You must login to post a comment. Don't have an account? Register to get one!

• 

  • #5

  rythos42 Sat, 06 Feb 2010 07:20:32

  This addon didn't look like it was being updated, so I made some modifications to it myself. Minor things like adding Isle, fixing Strand and the holiday calculations, which you've included in this update.

  But one thing I did that I thought was really useful was changing from using GloryLib to count win/losses, to using the statistics/achievement API to do it.

  Here's the gist of the changes:

  local BattlegroundWinStatisticIds = {
  	["Warsong Gulch"] = 105,
  	["Arathi Basin"] = 51,
  	["Alterac Valley"] = 49,
  	["Eye of the Storm"] = 50,
  	["Strand of the Ancients"] = 1550,
  	["Isle of Conquest"] = 4097,
  	["All"] = 840
  }
  
  function HonorFuPlus:GetBattlegroundWins(battlegroundName)
  	local wins = GetStatistic(BattlegroundWinStatisticIds[battlegroundName])
  	if wins == nil or wins == '--' then
  		return 0
  	end
  	return tonumber(wins)
  end
  
  local BattlegroundPlayedStatisticIds = {
  	["Warsong Gulch"] = 52,
  	["Arathi Basin"] = 55,
  	["Alterac Valley"] = 53,
  	["Eye of the Storm"] = 54,
  	["Strand of the Ancients"] = 1549,
  	["Isle of Conquest"] = 4096,
  	["All"] = 839
  }
  
  function HonorFuPlus:GetBattlegroundLosses(battlegroundName)
  	local winStatisticId = BattlegroundWinStatisticIds[battlegroundName]
  	local playedStatisticId = BattlegroundPlayedStatisticIds[battlegroundName]
  	
  	local games = GetStatistic(playedStatisticId)
  	local wins = GetStatistic(winStatisticId)
  		if games == nil or wins == nil or games == '--' or wins == '--' then 
  		return 0
  	end
  	return tonumber(games) - tonumber(wins)	
  end
  

  If you want to discuss this more, give me a shout: rythos42 at gmail.com or a PM here I'll bet will reach me :). If you want to use this, feel free to without talking with me first - it's a gift so this neat little mod continues to be useful to people :)

• 

  • #4

  Grilor Fri, 22 May 2009 15:36:20

  any chance we can get SOTA added tot his any time soon please?

• 

  • #3

  dtc11 Mon, 27 Oct 2008 17:13:11

  I know its a totally different program but is there anyway you can incorporate battleground fu, into this addon.

• 

  • #2

  gamemaster128 Thu, 16 Oct 2008 18:18:21

  Any chance of a 3.0.2 update soon? Broker support?

• 

  • #1

  gamemaster128 Thu, 16 Oct 2008 18:18:07

  Any chance of a 3.0.2 update soon? Broker support?