You must login to post a comment. Don't have an account? Register to get one!

• 

  • Reply
  • #7

  Archarodim Feb 05, 2011 at 21:29 UTC - 0 likes

  just to let you know that I'm still experiencing the issue. You should implement my fix to avoid the recursion loop.

  Author of Decursive, Healers Have To die and Sheepdog

• 

  • Reply
  • #6

  Archarodim Dec 29, 2010 at 01:13 UTC - 0 likes

  I've done some more testing and I found it's related to the quest POI integration, if I disable FlightHUD.db.profile.QuestPOI then everything is alright.

  The problem won't happen either if blizzard's quest tracker is off (no quest being followed at load time)

  The stack over flow is triggered by the ObjectivesChanged() function.

  If I comment the hook to "WatchFrame_Update" the problem will not occur

  Now this simply means that something you are doing in ObjectivesChanged() may trigger a WatchFrame_Update under certain conditions calling back ObjectivesChanged() again in a loop.

  The issue is easily fixed by making sure ObjectivesChanged() can't be run while it's already being executed.

  such as this (notice the new AlreadyInObjectivesChanged script local variable):
  

  local AlreadyInObjectivesChanged;
  function FlightHUD:ObjectivesChanged()
  
      if AlreadyInObjectivesChanged then
          return
      end
      AlreadyInObjectivesChanged = true; -- XXX
  
      -- Again, borrowing from other addons, namely TomTomLite (I love you, jnwhiteh). Mostly verbatim
      --[===[@debug@
      FlightHUD:Debug(DEBUG1, "ObjectivesChanged")
      --@end-debug@]===]
      QuestPOIUpdateIcons()
      if CurrentQuest ~= -1 then
          FlightHUD:RemoveWaypoint (CurrentQuest, true)
          CurrentQuest = -1
      end
      local watchIndex = 1
      while true do
          -- Get the first quest item in the watch frame
          local questIndex = GetQuestIndexForWatch(watchIndex)
          -- FlightHUD.db.profile.QuestPOI's toggle calls this function to remove the waypoint
          if not questIndex or not FlightHUD.db.profile.QuestPOI then
              -- There are no quests being tracked. Remove the waypoint
              AlreadyInObjectivesChanged = false; -- XXX
              return
          end
          if questIndex then
              local title = GetQuestLogTitle(questIndex)
              local qid = select(9, GetQuestLogTitle(questIndex))
              local completed, x, y, objective = QuestPOIGetIconInfo(qid)
              -- Check to see if there was coordinate information for the current point
              if x and y then
                  local map, floor = GetCurrentMapAreaID()
                  if not floor then floor = 0 end
                  if completed then
                      title = "Turn in: " .. title
                  end
                  if x and y and map and floor then
                      FlightHUD:AddQWaypoint (map, floor, x, y, title, L["Current Quest"], qid)
                  end
                  AlreadyInObjectivesChanged = false; -- XXX
                  return
              end
          end
          watchIndex = watchIndex + 1
      end
      AlreadyInObjectivesChanged = false; -- XXX
  end
  

  after this modification the problem is fixed. Now there is maybe a better way of doing that, maybe by hooking another function, I don't know...

• 

  • Reply
  • #5

  Barfolomeu Dec 13, 2010 at 22:50 UTC - 0 likes

  I also have Gathermate2 installed. I've been trying to bring this issue up in #wowdevui on Freenode, but no one seems interested. I've seen this happen at least 3-4 times now. It seems to have no ill effects. Not sure how to proceed.

• 

  • Reply
  • #4

  Archarodim Dec 13, 2010 at 22:14 UTC - 0 likes

  actually it's a conflict with GatherMate2, the problem occurs only when GatherMate2 is loaded after FlightHud...

• 

  • Reply
  • #3

  Archarodim Dec 13, 2010 at 22:06 UTC - 0 likes

  it seems to be systematical with me, I'm using 0.10.0 beta.
  It looks like an initialization issue...
  I made it load on demand and loaded it after my whole UI was loaded and I got no error.
  Astrolab must be accessing something when it's not there yet or something like that...

• 

  • Reply
  • #2

  Barfolomeu Dec 12, 2010 at 20:04 UTC - 0 likes

  Actually, I just noticed you said it was version 0.9.29. This was still using the old Astrolabe 0.4, which might not be supported any more.

• 

  • Reply
  • #1

  Barfolomeu Dec 12, 2010 at 20:02 UTC - 0 likes

  I've seen this too. It happened during ONE session of play, then never again. It also seems to be happening inside of Astrolabe. I honestly don't know what to make of this. I'm going to ask a few other developers to see what they think.