This is a Lua script that checks your .lua files for excess and/or involuntary global variable access.
It needs a Lua interpreter to run; I recommend Cogwheel's WoW Lua.
THIS IS NOT AN ADDON
Yes, it's basically a "Luac | grep ?ETGLOBAL", but with some controls.
In PARTICULAR, it differentiates between set/get global access inside and outside of functions.
It also lets you list globals that you are ok with in comment lines like "
--GLOBALS: blah, bleh, bluh".
So, it's a little more run-every-time-you-save-before-reloadui friendly. I've been using it for a bit and thought i'd share.
What do I need to know about globals for?
To optimize an addon's performance, you want to make access to commonly-used functions "local" access rather than global namespace lookups. This most definitely includes functions like type, next, pairs, select that maybe you didn't even realize were functions.
Some globals you may be okay with being global accesses (or in fact NEED them to because they can be hooked or changed), for those you have two options:
- Add one or more "
--GLOBALS: SomeFunc, SomeOtherFunc, SomeGlobalVariable" lines to the source file
- Put a "local _G=_G" at the top of the file, and then access them through _G.SomeFunc, etc. This is actually somewhat faster than accessing them directly, believe it or not. (Direct global access involves looking up the global variable table first!)
Then, and this is possibly the biggest boon of the script, there is finding the odd miss-spelled variable name. Or the code snippet that you copy&pasted from one function to another but forgot to rename the variables. This rocks.
How to run
Put globals.lua in some directory. Maybe along with your Lua interpreter. Then:
luac -l -p MyFile.lua | lua globals.lua MyFile.lua
or, more likely:
c:\path\to\luac -l -p MyFile.lua | c:\path\to\lua c:\path\to\globals.lua MyFile.lua
... since we're running Luac on the file, it is also checked for syntax errors.
I heartily recommend adding this as a "Tool" in your text editor of choice and binding it to a key that you can mash it to save & test before reloading your UI.
Oh and by the way, if you feel that this deserves a % of the curse points that go to libraries that you use, I'd appreciate a tools-used line in your .pkgmeta file :-)
- 7 comments