FeedTillers

4 - Add option to hide tillers with exalted/best friend reputation

What steps will reproduce the problem?
1.  Become exalted/best friends with a tiller
2. The tiller is still listed

There's no reason to keep doing the daily for a tiller once they are exalted.  Please add an option to hide tillers where rep has been maxed out.

User When Change
myrroddin Jan 22, 2013 at 12:51 UTC
myrroddin Jan 22, 2013 at 12:50 UTC
yunohu Dec 25, 2012 at 21:01 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 3 comments
  • Avatar of rainrider rainrider Apr 01, 2013 at 09:05 UTC - 0 likes

    @bsmorgan: Go

    Hiding best friends could be done easier by using the 9th return of GetFriendshipReputation which is nil for best friends.

    Find:

    			for i = 1, #npcs do
    				local npc = npcs[i]
    				if not npc.item then
    					npc.item = GetItemInfo(npc.itemID)
    				end
    				if not IsQuestFlaggedCompleted(npc.questID) then
    

    and replace by:

    			for i = 1, #npcs do
    				local npc = npcs[i]
    				local isNotBestFriend = select(9, GetFriendshipReputation(npc.factionID))
    				if not npc.item then
    					npc.item = GetItemInfo(npc.itemID)
    				end
    				if not IsQuestFlaggedCompleted(npc.questID) and isNotBestFriend then
    

    The code in based on the currently available addon version and not on the changes from bsmorgan

    Last edited Apr 01, 2013 by rainrider
  • Avatar of yunohu yunohu Dec 31, 2012 at 06:35 UTC - 0 likes

    Nice, thanks!

  • Avatar of bsmorgan bsmorgan Dec 28, 2012 at 23:23 UTC - 0 likes

    See my latest patch attached to Ticket 2, "Add coordinates for non-Halfhill locations". I've added this "feature" to my patch.

    Last edited Dec 28, 2012 by bsmorgan
  • 3 comments

Facts

Last updated
Jan 22, 2013
Reported
Dec 25, 2012
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees