Farmhand

4 - Taint issues causing errors with compact raid frames created afterwards.

Compact raid frames created after UIDROPDOWNMENU is tainted then are unsecure.  I've spent a lot of time so far tracking down these taint issues.  

3/1 07:47:06.413  Global variable UIDROPDOWNMENU_MENU_LEVEL tainted by Farmhand - Interface\FrameXML\UIDropDownMenu.lua:38
3/1 07:47:06.413      securecall()
3/1 07:47:06.413      Interface\FrameXML\UIDropDownMenu.lua:64 UIDropDownMenu_Initialize()
3/1 07:47:06.413      Interface\AddOns\Farmhand\Frames.lua:220

http://us.battle.net/wow/en/forum/topic/6933303515

Any raid frames created after the taint are unsecure and conflicts with ALOT of other addons.

User When Change
JCinDE Aug 28, 2013 at 03:22 UTC
John454ss Mar 01, 2013 at 14:01 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 4 comments
  • Avatar of JCinDE JCinDE Aug 28, 2013 at 03:22 UTC - 0 likes

    I just pushed v1.6.2b which removes the UIDropDownMenu entirely from the config page. Hopefully that clears it up.

  • Avatar of John454ss John454ss Aug 20, 2013 at 11:20 UTC - 0 likes

    I have a slight update on this problem. The latest version (1.6.1) still taints on startup/reload which is unfortunate because it's such an awesome addon. It just wreaks chaos with my mouseover macros and the compact unit frames.

    Beathscurse has an addon called "Simple Interrupt Announcer" which had the same issue and he seemed to fix it from the startup/reload point. His addon like yours if loaded by itself with nothing else tainted on startup/reload just like farmhand does without hitting escape and accessing the configuration panel.

    This might make more sense to you than me:

    "It's quite maddening really. I tried disabling one addon at a time, checking the taint log to see if UIDROPDOWNMENU_MENU_LEVEL got tainted, and I ended up having disabled all addons that had an entry in the configuration options panel. I guess it is more or less impossible to use UIDropDownMenu without getting this problem, and whatever addon happens to get flagged first is the one that is blamed.

    I have uploaded a beta where the dropdowns are not initialized before the configuration panel is shown. Of course this does not fix the issue, it just postpones it."

    Even just postponing the initialization like he did will fix the taint issue on startup/reload and make me a very happy person. Once the configuration panel is shown ANY addon in it taints, but a quick reload fixes it until next time the panel is shown.

    His addon and our converation about it:

    wow.curseforge.com/addons/sia/

  • Avatar of John454ss John454ss Mar 14, 2013 at 20:31 UTC - 0 likes

    Running no other addons but Farmhand produces a taintlog.  Do a "/console taintLog 2" and then only use farmhand.  Initially it's clean and untainted until it generates the menus by accessing the configuration panel.  I'm not sure there's anything you can do to fix it because I honestly think using Blizzard's UIDropDownMenu is just a horrendous taint factory.  About any addon once accessed through Blizzard's interface/addons configuration panel causes these taint issues.  In combat when secure raid frames need to be created they just freak out and target wrong targets, sometimes making frames untargetable.  The addon blamed is the first one accessed.  At this point I think this ticket is for your informational use only in case others run across this.  Healing once tainted using the raid frames is impossible as well as the "Blizzard has blocked..." messages start popping up.  These are all created by doing nothing other than accessing the configuration for farmhand.

    3/14 15:16:57.661  Global variable UIDROPDOWNMENU_MENU_LEVEL tainted by Farmhand - Interface\FrameXML\UIDropDownMenu.lua:38
    3/14 15:16:57.661      securecall()
    3/14 15:16:57.661      Interface\FrameXML\UIDropDownMenu.lua:64 UIDropDownMenu_Initialize()
    3/14 15:16:57.661      Interface\AddOns\Farmhand\Frames.lua:237
    3/14 15:16:57.661  Execution tainted by Farmhand while reading UIDROPDOWNMENU_MENU_LEVEL - Interface\FrameXML\UIDropDownMenu.lua:48
    3/14 15:16:57.661      securecall()
    3/14 15:16:57.661      Interface\FrameXML\UIDropDownMenu.lua:64 UIDropDownMenu_Initialize()
    3/14 15:16:57.661      Interface\AddOns\Farmhand\Frames.lua:237

  • Avatar of JCinDE JCinDE Mar 10, 2013 at 01:13 UTC - 0 likes

    As the link you included notes and as my further research indicates, the taint issues are encountered when an addon creates 8 or more dropdown menu items.

    Farmhand creates only 2. Therefore, wouldn't it be unlikely that Farmhand is causing your taint problems?

  • 4 comments

Facts

Last updated
Aug 28, 2013
Reported
Mar 01, 2013
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees