EavesDrop

9 - sourceName & destName nil

What steps will reproduce the problem?
1. Enable Eavesdrop
2. Fight a raidboss with some kind of vehicle/npc giving healing/randomly on random boss (like Ambershaper in HoF, Twin Consorts in ToT and rarely on random bosses like Lei-Shen in ToT)
3. Wait for those things to happen

What is the expected output? What do you see instead?
Expected to see nothing, got instead ton of lua errors everytime those things happen.

What version of the product are you using?
2.52 from Curse.com

Do you have an error log of what happened?
From BugSack:
-----
7x EavesDrop\EavesDrop-v2.52.lua:548 attempt to concatenate local "destName" (a nil value)
EavesDrop\EavesDrop-v2.52.lua:548 in function "?"
Libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:147 in function <Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
<string>:"safecall Dispatcher[19]":4: in function <string>:"safecall Dispatcher[19]":4
<in C code>
<string>:"safecall Dispatcher[19]":13: in function "?"
Libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92 in function "Fire"
ActionSwap2-1.1.4\Libs\AceEvent-3.0\AceEvent-3.0-3.lua:120 in function <ActionSwap2\Libs\AceEvent-3.0\AceEvent-3.0.lua:119

Locals:
nil

-----

162x EavesDrop\EavesDrop-v2.52.lua:532 attempt to concatenate local "sourceName" (a nil value)
EavesDrop\EavesDrop-v2.52.lua:532 in function "?"
Libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:147 in function <Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
<string>:"safecall Dispatcher[19]":4: in function <string>:"safecall Dispatcher[19]":4
<in C code>
<string>:"safecall Dispatcher[19]":13: in function "?"
Libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92 in function "Fire"
ActionSwap2-1.1.4\Libs\AceEvent-3.0\AceEvent-3.0-3.lua:120 in function <ActionSwap2\Libs\AceEvent-3.0\AceEvent-3.0.lua:119

Locals:
nil

-----

Please provide any additional information below.
Mostly annoys you when you are in amber construct in Ambershaper fight (get errors everytime), recieve healing from Dragon on Twin Consorts fight (get errors everytime) and sometimes randomly on Lei-Shen and other fights.

User When Change
ahak Apr 02, 2013 at 22:16 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of ahak ahak Oct 15, 2014 at 13:10 UTC - 0 likes

    This wasn't fixed in 6.0 release or wasn't mentioned in changelog?

  • Avatar of cseg cseg Jul 11, 2013 at 19:41 UTC - 0 likes

    I have a temporary, hack'n'slash workaround for this until an official fix is released. Change line 532 to this:

    if (db["HEALERID"] == true and not fromPlayer) then text = text.." ("..(sourceName or "Unknown")..")" end
    

    and line 548 to this:

    if (db["HEALERID"] == true) then text = (destName or "Unknown")..": "..text end
    

    These changes will make EavesDrop show "Unknown" for units it doesn't recognize (I found this bug while questing in Townlong Steppes, killing Osul Mist-Shamans and getting healed by Surrounding Mists).

    Again, this is a very simple hack just to make the addon not spill errors in those situations, and not meant to be taken as an official fix.

  • 2 comments

Facts

Reported
Apr 02, 2013
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees