DropTheCheapestThing

7 - Drop items with no vendor value

DropTheCheapestThing doesn’t seem to know what to do with items that don’t have a vendor value, like Ruined Tome, even if I add them to my “Always Consider” list. I think it should pretend these items have a vendor value of zero, and let me drop them. :)

User When Change
Akkorian Feb 05, 2011 at 10:00 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of Phanx Phanx Jul 22, 2014 at 11:19 UTC - 1 like

    Came to post a ticket about this after modifying my local copy for about the 100th time post-update and I see it was already requested years ago... maybe some code will help get it implemented faster. :P

    In addon.lua, change line 193 in GetConsideredItemInfo from:

    if (not value) or value == 0 then return end
    

    to:

    if not value then value = 0 end
    

    It did just occur to me that you should probably also add a check for quest items, but since my default threshold is still set to gray, I've never had a problem with that. You could also only allow dropping zero-value items if they were on the "always drop" list.

  • Avatar of mikk mikk Mar 20, 2012 at 16:52 UTC - 0 likes

    Absolutely. If I add something to the "Always Consider" list, it's because I _want_ them dropped!

  • 2 comments

Facts

Last updated
Sep 09, 2014
Reported
Feb 05, 2011
Status
New - Issue has not had initial review yet.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
2

Reported by

Possible assignees