DrDamage

288 - r1962 MM Hunter Tooltip miscalc/miscalc on target

What is your Race, Class and Level?
Human, Hunter, 82

What action bar mod do you use, if any?
Bartender 4

What is the expected output? What do you see instead?
Average total damage expected, but is calculated/displayed wrong (when a target is choosen; see below).

If this is an accuracy issue, what is your exact spec and your damage attributes? (For spells SP, for melee abilities AP/RAP, weapon etc.). Armory links are helpful.
My spec is marksman, but this bug is independent of attributes.

What version of DrDamage are you using?
r1962

Do you have an error log of what happened?
no

Please provide any additional information below.

As marksman hunter you have 3 passive dps gains: Wild Quiver (mastery), Piercing Shots and Careful Aim.

Wild Quiver is currently calculated/displayed correctly on shots, but wrongly added to Serpent Sting aswell.
Piercing Shots is currently wrongly calculated/displayed for all shots, aswell as Serpent Sting and Explosive Trap instead of only for Aimed Shot, Steady Shot and Chimeara Shot.
Careful Aim is currently wrongly calculated/displayed for all skills for targets above 80% health instead of only applying to Steady Shot and Aimed Shot for targets above 80% health.

User When Change
angosia May 21, 2013 at 20:19 UTC
Goddamnedmaster May 21, 2013 at 09:09 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 5 comments
  • Avatar of angosia angosia May 21, 2013 at 22:38 UTC - 0 likes

    @Goddamnedmaster: Go

    I'll look into it probably tomorrow. I suspect I know what the problem is. As for what it will take to fix... heh. If I can't figure it out, I'll nag Gagorian.

  • Avatar of Goddamnedmaster Goddamnedmaster May 21, 2013 at 21:49 UTC - 0 likes

    Hm, nope, didn't fix it. Thanks for the try anyway..I think one can live with it for now Maybe you will find and fix the error later. Will report any further issues when I find some.

  • Avatar of angosia angosia May 21, 2013 at 21:42 UTC - 0 likes

    @Goddamnedmaster: Go

    Hmm. I'm not sure if I can fix it, but I'll try. I've added additional logic to Wild Quiver. But, what was there before should have worked, so I'm not entirely sure this will fix it if the previous did not.

    Beyond that, it may require additional code if r1965 doesn't work.

  • Avatar of Goddamnedmaster Goddamnedmaster May 21, 2013 at 21:27 UTC - 0 likes

    Hmm, Careful Aim and Piercing Shot seem fixed, however Wild Quiver still appears in the tooltip of Serpent Sting. Good job on the rest so far :) ty

    Last edited May 21, 2013 by Goddamnedmaster
  • Avatar of angosia angosia May 21, 2013 at 20:19 UTC - 0 likes

    It looks like the code was there, in the old talents section - updated for Mists. However, those options didn't seem to have worked. So, I reworked it to a consistent model we've used before. Let me know if that works. This is in r1964.

  • 5 comments

Facts

Last updated
May 21, 2013
Reported
May 21, 2013
Status
Accepted - Problem reproduced / Need acknowledged.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees