You must login to post a comment. Don't have an account? Register to get one!

• 

  • #50

  Ekovah Wed, 26 Nov 2008 12:28:14

  Hi bigheph,

  Thank you so much for posting your fix :). I updated my mage.lua accordingly and FFB DPS calculation seems to be more accurate now (actually increased, so getting closer to reality). But in addition to the missing glyphs issue you're pointing at, I don't know why my FFB tooltip is still displaying wrong numbers for crit rate (still displaying my base crit rate instead of the rate corrected by talents), don't know if it's a display problem of if the wrong crit rate is used for calculations.

  Regards, Ekovah

  PS: Congratulation for your level up Dally1991 xD Please don't spend too much time on your DK in order to save time for fixing this great plugin ! :)

• 

  • #49

  bigheph Wed, 26 Nov 2008 05:16:55

  you can open the mage.lua with a .txt reader like wordpad or something. if u scroll to the bottom u'll find areas that lists all the talents by spell numbers, u can search wowhead to find out what each number = in talent

  anyway heres what i changed, be warned, what i changed doesnt make it 100% accurate, just a bit closer in the right direction, tbh i dont see what is wrong with the original code that didnt allow frostfire bolt to be classed as "Frost" and not add the dmg...

  anyway, i'd recommend backing up before changing anything i have, im not exactly a pro coder. lol. the part changed is just under the --Chilled to the Bone comment in the mage.lua

  [GetSpellInfo(31670)] = { [1] = { Effect = { -1.75, -3.5, 5 }, Spell = "Frost Nova", ModType = "cooldown" }, [2] = { Effect = { -0.7, -1.4, -2 }, Spell = "Cone of Cold", ModType = "cooldown" }, }, [GetSpellInfo(11207)] = { [1] = { Effect = (1/6), Spells = { "Frostbolt", "Frostfire Bolt" }, ModType = "critM", }, }, [GetSpellInfo(29438)] = { [1] = { Effect = 1, Spells = { "Frost", "Fire", "Frostfire Bolt" }, ModType = "hitPerc" }, }, [GetSpellInfo(11151)] = { [1] = { Effect = 0.02, Spells = { "Frostbolt", "Frostfire Bolt" }, }, }, [GetSpellInfo(11170)] = { [1] = { Effect = {17, 34, 50}, Spells = "All", ModType = "Amount", Value = "Shatter" }, }, [GetSpellInfo(11190)] = { [1] = { Effect = { 0.15, 0.25, 0.35, }, Spells = "Cone of Cold", }, }, [GetSpellInfo(55091)] = { [1] = { Effect = { -3, -6 }, Spell = "Ice Barrier", ModType = "cooldown" }, }, [GetSpellInfo(31674)] = { [1] = { Effect = 0.01, Spells = "Frost", }, }, [GetSpellInfo(31682)] = { [1] = { Effect = 0.05, Spells = "Frostbolt", ModType = "SpellDamage", Multiply = true}, [2] = { Effect = 2, Spells = "Frostbolt", ModType = "critPerc" }, }, [GetSpellInfo(44566)] = { [1] = { Effect = 0.01, Spells = { "Frostbolt", "Frostfire Bolt", "Ice Lance" }, }, }, }

• 

  • #48

  Dally1991 Tue, 25 Nov 2008 10:51:53

  Hello all,

  I've managed to hit 80 on my Druid. I'm really enjoying my playtime!

  I really appreciate the bug reports that have been filed so far. I will be resuming work on DrDamage very soon to squash all those annoying issues that have shown themselves.

  I've also got a level 60 DK that I'm working on, and I'm missing those numbers as much as the rest of you, so I will get to work on adding official DK support to DrDamage soon.

  Cheers, Dally

• 

  • #47

  Ekovah Tue, 25 Nov 2008 07:43:16

  bigheph said: [quote]then i edited the mage.lua to change the frost trees talents to include frostfire bolt[quote]

  Hi bigheph, how did you do that ? I've tried to get into the mage.lua by myself but didn't manage to find where and how to modify the file. I'd appreciate whether you can post you modification here.

  Thanks ! Ekovah

• 

  • #46

  bigheph Tue, 25 Nov 2008 00:27:57

  at first it was reporting 4.4k crits as my max dmg for frostfire bolt, then i edited the mage.lua to change the frost trees talents to include frostfire bolt, even tho frostfire bolt is being called to fall in the "Frost" global category, i dont think it was working for the frost talents aswell as the fire, manually adding frostfire bolt to those talents brought it extremely close to the expected value it should be reporting. now i think its just missing glyph dmg and meta dmg bonuses to bring it up to the correct dmg it should be doing

  things i think you need to double check: - can more than one global spell category like "Frost" and "Fire" be called for dmg calculations in the tooltip? adding frostfire bolt manually to the talents seemed to work for the frost tree talents it is affected by - are glyphs being calculated - have the new meta gems been added

• 

  • #45

  kouik Sat, 22 Nov 2008 23:54:55

  Salokin, there is a big missing point on your bug report.

  Can you attach a link to your template ? It will help to check what can be the problem ;)

• 

  • #44

  Salokyn Sat, 22 Nov 2008 20:30:50

  Hello, here some values to correct druid heal coefficients. My spellpower is 1056 and i'm lvl 75.

  Lifebloom (rank 2) tick :
  DrDamage value : 246.2 HP
  Real value : 195.5 HP
  Lifebloom final tick is good (1746 HP).

  Rejuvenation (rank 13) :
  DrDamage value : 926.8
  Real value : 964

  Regrowth (rank 11)
  Drdamage values : Avg = 2737 Tick = 544.2
  Real values : Avg ~ 2850 Tick ~ 568.5

• 

  • #43

  kouik Thu, 20 Nov 2008 13:40:11

  Dally, I'm somewhat silly....

  For the email, if you tried to reach me, please read :

  kouik 03 at gmail dot com .....

• 

  • #42

  kouik Thu, 20 Nov 2008 00:08:02

  hum, okay.

  but, I'm really surprising on how you will get things changed.

  At the moment, I began to understand how to do better things with disease detection, and how to calculate damage per rune/runic power without changing too much the core.

  This can really function, as efficient as possible, without any incompatibilities ;)

  But, I've no problem with that, it is very good if some things are changed, in particular comments, are some parts of the code are really cryptic ;)

  My work won't be loosed I thing, as for DK more than any other class, there is a lot of exceptions, special cases, where things apply or not (you'll see in the code, and not only for the number of diseases).

  Regarding the number, to be clear, I took more than ten hours today to validate them by striking against a trainer, with recount, spreadsheet, to check that all was ok. So even if the core is broken, we will have numbers ready. This really worth the try, as I plan when I'll be happy with unholy to work on blood ;)

  If you have some things that you can share on how you will implement, I'm pretty sure that we can work together, for best efficience, and maybe share idea and remove some bottleneck/cluttering of the current code ;)

  If you want to contact me, feel free to kouik 31 at gmail dot com

  
  Kind Regards.

  kouik.

  
  

• 

  • #41

  Dally1991 Wed, 19 Nov 2008 17:40:02

  kouik,

  I appreciate the work you're doing for the DKs. However, because of the way I plan to approach implementing them into DrDamage, it will be incompatible with the way you've worked in DK support.

  You're welcome to continue working on your clone until I implement support in the mainline, but I just wanted you to be aware that I won't be merging your code into the main branch since I'll be writing it from scratch.

  Cheers, Dally1991