You must login to post a comment. Don't have an account? Register to get one!

• 

  • #61

  Dally1991 Fri, 05 Dec 2008 23:25:21

  I've kept a separate secondary effect simply because Blizzard has done a wonderful job of making the tooltip ambiguous and confusing. I was originally led to believe that it would apply frost effects to the frost version of FFB and fire effects to the fire version, and whichever would do more damage to the target (after resistances and buffs/debuffs are taken into account) is the one that ended up occurring.

  But now I'm of the impression that all frost and fire effects are applied to BOTH versions of FFB, and that the only deciding factor is the target's fire/frost resistances? In which case, I guess there really is absolutely no point in keeping separate fire and frost versions of FFB... Am I correct in this?

  I've done the following:

  • Commented out the secondary effect of FFB.
  • Set the "School" of FFB to "Frostfire" so it will trigger the calculation I added in Caster.lua for frostfire crits.
    • This will have the unfortunate effect of excluding things such as potions and other (non-mage originating) buffs/debuffs such as the ones in Aura.lua, which boost fire or frost damage. I will have to go through this later and make sure that these are taken into account properly.
  • Changed the EP talent similar to your suggestion, the first effect applies to Frost, Fire and Frostfire, and the second effect applies to Frostfire Bolt. In theory, this should result in FFB gaining 1-3% hit from being in the Frostfire school, and another 1-3% hit for being the spell "Frostfire Bolt". DrDamage has a habit of not enjoying my hacks, so let me know if this last one doesn't take effect as planned.

  
  Thanks for the help zoeckler, let me know how my changes go!

• 

  • #60

  zoeckler Fri, 05 Dec 2008 22:06:15

  The major theorycrafters agree that FFB gets double benefits from EP... from my last post: ...since it has been shown that frostfire bolt gets double benefit from the +hit talent, i fixed it by doing this:

  [GetSpellInfo(29438)] = { [1] = { Effect = 1, Spells = { "Frost", "Fire" }, ModType = "hitPerc" }, [2] = { Effect = 1, Spells = "Frostfire Bolt", ModType = "hitPerc" }, },

  ALSO, FFB is showing base crit chance, not the fireCrit+frostCrit-baseCrit that you set up in the caster.lua. Once you get that working... it would be correct. - i want to mention, however, that no talents right now increase frost crit chance above baseCrit... so this function is technically not needed at this time.

  oh, i found one of the issues... in the spell detail area, you swapped the frostfire order so that it is classified as "Frost" first, then "Fire"... it seems that the [secondary] is not doing anything functional (which I already knew)... so as of the latest build is is only classifying FFB as "frost", and therefore showing only frostCrit in the tooltip (which is the same as baseCrit).

  i fixed this locally by removing the [secondary] from FFB and putting in in the "fire" school. The modifications to the frost talents themselves should take care of the rest.

• 

  • #58

  Dally1991 Thu, 04 Dec 2008 08:14:04

  kouik,

  Repository access is not under my control as I am not project leader. Please feel free to continue posting tickets that's what they're there for after all. =)

• 

  • #57

  Dally1991 Thu, 04 Dec 2008 08:12:22

  Ekovah,

  Are you sure FFB gets twice the effect of Elemental Precision? I'll try and verify this independently, sounds a little fishy but possible.

  As for crit damage, I'll look into that. I'm not sure why max would be correct but min would not. They should both (in theory) be off by the same margin.

• 

  • #56

  kouik Wed, 03 Dec 2008 14:14:49

  Hello Everybody

  I opened tickets 20 to 26 with some code changes to solve minor issues/glitches.

  Dally, thanks for this release. Can I ask you an access to the repository ? It could be really good for me to directly put updates and not posting tickets ;)

  I won't stop to correct things for death knight, and I only use values that I tested on a training dummy, or a monster. Otherwise, when I have a doubt, I always write a clear comment to allow anyone to check/change things.

  Thanks in advance ;)

• 

  • #55

  Ekovah Wed, 03 Dec 2008 13:18:50

  Hi Dally,

  r706 fixes my display issue. 3 remarks regading FFB:

  1. Frostfire glyph bonuses are not taken into account in FFB calculations (+2% crit +2% spell power on FFB)

  2. Double hit bonus from Elemental Precision on FFB is not taken into account(usually +3% hit, becoming +6% hit on FFB by accumulating +3% hit on fire +3% hit on frost)

  3. Crit dmg calculation is still wrong : the max crit dmg is ok (around 10k) but the min crit dmg is too high (10k in r706 but actually closer to 6k in game).

  I'll further investigate and keep you informed.

  Thank you :)

  Cheers, Ekovak

• 

  • #54

  Dally1991 Wed, 03 Dec 2008 00:56:39

  Hi Ekovah.

  Do you have an error report? My mage is only 57, so I'm unable to test changes made to Frostfire. The best I can do is dry-code and hope it works.

• 

  • #53

  Ekovah Tue, 02 Dec 2008 19:31:45

  Great Dally, you rocks :) Thank you

  Edit: oups no display on my bars with r705 ://

• 

  • #52

  Dally1991 Tue, 02 Dec 2008 18:50:12

  Thanks zoeckler, I've made the rating changes. Hopefully they work!

• 

  • #51

  zoeckler Sun, 30 Nov 2008 20:49:18

  function DrDamage:GetLevels()

  if targetLevel == -1 then if playerLevel >= 70 then targetLevel = 83

  this needs to be updated in drdamage.lua it currently is still using level 73 as boss level.

  it seems the function DrDamage:GetRating( rType, convertR, full ) function also needs an update... though i am unsure what to change.

  also, thanks for posting the frostfire bolt changes. adding the spell anytime "frost" is included does work great. However, since it has been shown that frostfire bolt gets double benefit from the +hit talent, i fixed it by doing this:

  [GetSpellInfo(29438)] = { [1] = { Effect = 1, Spells = { "Frost", "Fire" }, ModType = "hitPerc" }, [2] = { Effect = 1, Spells = "Frostfire Bolt", ModType = "hitPerc" }, },