You must login to post a comment. Don't have an account? Register to get one!

• 

  • Reply
  • #7

  dwex Oct 21, 2008 at 22:20 UTC - 0 likes

  Need to replace instances of 'FlightFormDefault' with 'profile.FlightFormDefault' in Coconuts:GetStateBasedOnModifiers(). Then it works right.

• 

  • Reply
  • #6

  LordFarlander Oct 21, 2008 at 15:29 UTC - 0 likes

  This should be fixed now. I need to do more testing to verify.

• 

  • Reply
  • #5

  dwex Oct 20, 2008 at 22:10 UTC - 0 likes

  FYI - as a test, I changed:
  

  if( self.CurrentFlying ) then
       self.Mode = "Mount";
       return self.CurrentFlying;
  end--if
  

  to
  

  if( self.CurrentFlyingForm ) then
      self.Mode = "Mount";
      return self.CurrentFlyingForm;
  elseif( self.CurrentFlying ) then
      self.Mode = "Mount";
      return self.CurrentFlying;
  end--if
  

  in Coconuts:GetStateBasedOnModifiers() and this seems to work right on my druid and non-druids. That's not a real fix, but a confirmation that the logic is otherwise sound.

  I'd also suggest adding forms to the list of available mounts (the printed list); when I started debugging this, I had to add debug-prints to make sure Flight Form was being detected at all.

• 

  • Reply
  • #4

  dwex Oct 20, 2008 at 15:35 UTC - 0 likes

  Thanks. This is the one thing keeping me from using Coconuts. An excellently-designed addon, with a good mix of simple defaults and complex config for those who want to "play".

• 

  • Reply
  • #3

  LordFarlander Oct 20, 2008 at 15:14 UTC - 0 likes

  Thank you for looking into this. I have time now to look at this (mount issues took presidence I'm afraid) You are correct that for flight forms, it should default to the form and not the mount. :) Or there should be an option to do so (this is what I'm likely going to do)

• 

  • Reply
  • #2

  dwex Oct 20, 2008 at 14:44 UTC - 0 likes

  Been looking into this some. I have some code changes I will try when I get home.

  I think the error is in the logic in Coconuts:GetStateBasedOnModifiers(). In particular, I see two problems:

  - Flight form seems to be tied to the 2nd-best modifier. Which is probably correct for ground mounts, but not for flying, where instant-cast flying probably causes druids to just use flight form, in preference to flying mounts, except for vanity mount situations. This may want to be split into a separate preference for flight vs ground forms.
  - Even if that were bypassed, the form check is INSIDE the conditional for Self.NextCurrentXXX Well, as a druid with epic flight form, I have no "normal" flying mounts. Hence Self.CurrentFlying/Self.NextCurrentFlying will always be nil, and the form check is never made.

  Basically, this code needs a bit of restructuring to (a) do form checks independent of any 'real' mounts, and (b) give precedence to flight form over 'real' mounts.

  I'll test that out tonight and post an update.

• 

  • Reply
  • #1

  dwex Oct 19, 2008 at 14:57 UTC - 0 likes

  Still not working with 2.5.94 downloaded from WoWI today.