WowAce.com

ClosetGnome

6 - Not unequiping items with 'naked'-set

What steps will reproduce the problem?
Make a set with empty slots only!
Equip items
Tell CG to equip the 'naked' set

What is the expected output? What do you see instead?
CG should unequip the items

What version of the product are you using?
r579 (latest)

Tracked it down
The problem is in ClosetGnome:IsSetFullyEquipped, more so in the line:
--------------------
        if slot > 0 and item and not IsEquippedItem(item) then
            return false
        end
--------------------
The problem is, item is false for empty slots and nil for slots not active in the set, so this if will always return false for 'naked sets' and CG thinks the set is already fully equiped by the char
--------------------
        if slot > 0 and (item or item == false) and not IsEquippedItem(item) then
            return false
        end
--------------------
item is nil for inactive slots which evaluates to false, but item is false for empty slots, thats the problem, with this change CG unequips empty slots as expected.

User When Change
Rabbit Fri, 28 Aug 2009 17:49:36 Changed status from New to Fixed
Starfox Sat, 25 Oct 2008 23:09:40 Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Last updated on
28 Aug 2009
Reported on
25 Oct 2008
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.

Reported by

Possible assignees

Votes (Total: +9, Average: +3.0)