Fix searching #26


  • New
  • Defect
Closed
Assigned to dhedbor
  • spiralofhope created this issue Jul 22, 2016

    Using 7.0.0 on WoW 7.0.3 (22248)

    With a very-full inbox, typing in the search bar is extremely slow.

    My test case is:

    • Many many items.
    • One mail with cash
    • in the Bulk Mail Inbox search bar, type 'cash'
    • My game freezes, let go of the keyboard
    • After some time, the BMI window appears at the bottom of the screen.
      • Feature request: It should instead still appear with its top edge where it used to be
    • 'cash' is accepted as the search item (it appears in the search bar), and that cash mail is shown.
    • Click 'take all'
    • The cash is taken, but an item is also taken.
  • spiralofhope added the tags New Defect Jul 22, 2016
  • spiralofhope posted a comment Jul 22, 2016

    I brain farted and forgot to test with other addons disabled.

    • The freezing issue remains
    • The BMI window does not move.
    • I did not have more gold in that inbox, so I did a search for an item (blackrock ore) and could not reproduce a 'take all' bug.
    • shift-click on an item freezes in the same way as typing. I guess this is a window update issue.

    Edited Jul 22, 2016
  • RubioTwitch posted a comment Jul 28, 2016

    Add
       tooltip:Hide()
    to the ShowInboxGUI() function in the 'else' branch of the "if not tooltip" test (line 974 i believe):

    function mod:ShowInboxGUI()
        [...]
      if not tooltip then
        [...]
      else
         tooltip:Hide()                      -- add THIS to stop the horrible lag
         tooltip:Clear()
      end
    [...]

    this should fix it.  

    it seems the tooltip being updated with lots of rows while also not hidden makes it take incrementally longer for each call to tooltip:AddLine(...), getting longer by ~10ms (on my system) per item added; once you've added above 100 items to the tooltip, each subsequent tooltip:AddLine(...) call to an existing & visible tooltip (even though it's been Clear()ed) is taking upwards of 100ms per item.  With around 100 items in the inbox, this cumulative delay is lagging the entire UI by at least 3 seconds per InboxGUI refresh--which happens every time cash or an item is taken from the inbox.  With 200 items it's taking more like 15 seconds per refresh, making everything completely unusable.

    Adding the tooltip:Hide() fixes this for me beautifully.

  • KyrosKrane posted a comment Jul 28, 2016

    @Rubio9: Go

    Confirmed that this appears to fix the lag issue. I haven't noticed any other issues crop up as a result of this change.

  • Nulgar posted a comment Sep 25, 2016

    Thanks Rubio, I was having short freezes even from opening the inbox due to several mails with up to 12 green BoEs. Search worked fine though, was even my workaround when I had to switch between inbox and send tab several times :P

  • Nulgar posted a comment Sep 25, 2016

    Hmm, but now the search box gets unfocused when I type a letter...

  • DHedbor closed issue Sep 17, 2019
  • DHedbor posted a comment Sep 17, 2019

    So this should be fixed.. finalkly :)


To post a comment, please login or register a new account.