!BugGrabber

54 - Script run too long

What steps will reproduce the problem?
1.Combat
2.
3.

What is the expected output? What do you see instead?
The chat is full of: "Interface\AddOns\!BugGrabber\BugGrabber.lua:370 script run too long

What version of the product are you using?
r188

Do you have an error log of what happened?
!BugGrabber-r188\BugGrabber.lua:587 in function <!BugGrabber\BugGrabber.lua:587
<in C code>
FrameXML\FlowContainer.lua:157 in function "FlowContainer_DoLayout"
FrameXML\FlowContainer.lua:17 in function "FlowContainer_ResumeUpdates"
Blizzard_CompactRaidFrameContainer.lua:185 in function "CompactRaidFrameContainer_LayoutFrames"
Blizzard_CompactRaidFrameContainer.lua:130 in function "CompactRaidFrameContainer_TryUpdate"
Blizzard_CompactRaidFrameContainer.lua:57 in function "CompactRaidFrameContainer_OnEvent"
<string>:"*:OnEvent":1: in function <string>:"*:OnEvent":1

Locals:
nil

!BugGrabber-r188\BugGrabber.lua:587 in function <!BugGrabber\BugGrabber.lua:587
<in C code>
Blizzard_CompactRaidFrameManager.lua:559 in function "CompactRaidFrameManager_LockContainer"
Blizzard_CompactRaidFrameManager.lua:552 in function "CompactRaidFrameManager_UpdateContainerLockVisibility"
Blizzard_CompactRaidFrameManager.lua:46 in function <Blizzard_CompactRaidFrameManager.lua:39

Locals:
nil

!BugGrabber-r188\BugGrabber.lua:587 in function <!BugGrabber\BugGrabber.lua:587
<in C code>
FrameXML\CompactUnitFrame.lua:276 in function "CompactUnitFrame_UpdateVisible"
FrameXML\CompactUnitFrame.lua:234 in function "CompactUnitFrame_UpdateAll"
FrameXML\CompactUnitFrame.lua:96 in function <FrameXML\CompactUnitFrame.lua:43

Locals:
nil

Please provide any additional information below.

User When Change
funkydude Nov 30, 2014 at 19:35 UTC Changed status from Replied to Fixed
DarkLimpan Jul 06, 2014 at 07:34 UTC Changed status from Waiting to Replied
funkydude Nov 28, 2013 at 04:11 UTC Changed status from Replied to Waiting
Clamsoda Nov 20, 2013 at 18:20 UTC Changed status from Waiting to Replied
funkydude Nov 19, 2013 at 15:15 UTC Changed status from Replied to Waiting
Clamsoda Nov 08, 2013 at 16:16 UTC Changed status from Waiting to Replied
funkydude Oct 21, 2013 at 13:59 UTC Changed status from New to Waiting

Changed assigned to from Rabbit to funkydude
seaquake Oct 22, 2012 at 18:06 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 9 comments
  • Avatar of funkydude funkydude Nov 30, 2014 at 01:02 UTC - 0 likes

    Don't think tweaking this any more will help. It still only takes ~1ms if it's a new error, ~0.2ms if it's a repeat error. It's obviously just the debuglocals function in specific taking way too long, most likely in situations where the addon causing the error has a metric ton of them, or giant tables.

    I'm disabling logging locals in combat.

  • Avatar of Farmbuyer Farmbuyer Nov 26, 2014 at 19:55 UTC - 0 likes

    Using r205 (the latest as I write this), I'm seeing the same problems as DarkLimpan in comment #7. Every 10 seconds in combat, an unformatted "script ran too long" error is printed for line 368.

    I also have BugSack installed, but none of the errors ever arrive there. This makes sense, as the location is...

        -- Store the error
        errorObject = {
            message = sanitizedMessage,
            stack = table.concat(tmp, "\n"),
            locals = debuglocals(4),   -- line 368
            session = addon:GetSessionId(),
            time = date("%Y/%m/%d %H:%M:%S"),
            counter = 1,
        }
        ....
        addon:StoreError(errorObject)
        triggerEvent("BugGrabber_BugGrabbed", errorObject)
    

    ...so none of the buggrabber clients will see it. Thus, I don't have a stack trace of what's causing the original error. (I see the error in Bloodmaul Slag Mines every time I'm there, fwiw. The last yard trash before the fire elemental on the bridge; that trash pack fight always triggers something which results in this error.

    I've tried changing line 589 from "registerAddonActionEvents()" to "unregisterAddonActionEvents()" but am still seeing this error message. So it doesn't seem to be a bad-addon-flag triggering this.

  • Avatar of DarkLimpan DarkLimpan Jul 06, 2014 at 07:34 UTC - 1 like

    @funkydude

    I've had a similar issue for months where chat gets full of "Interface\AddOns\!BugGrabber\BugGrabber.lua:368 script run too long" with 10 second intervals, during combat in raid finder (although it can occur in my 10man raid as well). I currently use r202 of BugGrabber. I'd be damned if I knew what's causing this.

    Should I put up a new ticket for this issue?

  • Avatar of funkydude funkydude Nov 28, 2013 at 04:11 UTC - 0 likes

    Please also post an updated script too long error so I can see what line it's choking on. Also make sure you're using the latest alpha.

  • Avatar of Clamsoda Clamsoda Nov 20, 2013 at 18:20 UTC - 0 likes

    @Funydude

    I fixed the error that was causing it to happen; let me revert the change and see if I can provoke it.

    For what it is worth: The tooltip AddOn I am using (FreeBTip) would throw an error during Proving Grounds or Legendary Meta Scenario, which would in-turn cause BugGrabber to have the "Script run too long" issue.

    Solving the tooltip issue fixed the BugGrabber issue. I will try to induce it in a bit.

    Edit: I tried to get the error to provoke the script ran too long issue, but wasn't able to get there. As clarification, I got the script ran too long after about 3 hours of attempts, all of which had the same error. Here is the error that eventuallu provoked it:

    308x FreebTip-2.7\tip.lua:421: bad argument #2 to "format" (string expected, got nil)
    <in C code>
    FreebTip-2.7\tip.lua:421: in function <FreebTip\tip.lua:377>
    <in C code>
    <in C code>
    FrameXML\UnitFrame.lua:398: in function "UnitFrame_UpdateTooltip"
    FrameXML\UnitFrame.lua:385: in function <FrameXML\UnitFrame.lua:372>
    
    Locals:
    self = GameTooltip {
     0 = <userdata>
     SetInboxItem = <function> defined =[C]:-1
     freebHeightSet = 5
     shoppingTooltips = <table> {
     }
     GetBackdropColor = <function> defined @Interface\AddOns\FreebTip\tip.lua:624
     SetQuestLogItem = <function> defined =[C]:-1
     SetGuildBankItem = <function> defined =[C]:-1
     SetTradeTargetItem = <function> defined =[C]:-1
     default = 1
     SetTradePlayerItem = <function> defined =[C]:-1
     GetBackdropBorderColor = <function> defined @Interface\AddOns\FreebTip\tip.lua:631
     SetSendMailItem = <function> defined =[C]:-1
     updateTooltip = 0.070999994222075
     SetInventoryItem = <function> defined =[C]:-1
     freebtipUpdate = 0.077999999187887
     comparing = false
     SetLootRollItem = <function> defined =[C]:-1
     SetUnitAura = <function> defined =[C]:-1
     freebtipBD = true
     SetAuctionSellItem = <function> defined =[C]:-1
     SetBagItem = <function> defined =[C]:-1
     SetHyperlink = <function> defined =[C]:-1
     SetTradeSkillItem = <function> defined =[C]:-1
     SetLootItem = <function> defined =[C]:-1
     SetQuestItem = <function> defined =[C]:-1
     SetAuctionItem = <function> defined =[C]:-1
    }
    _ = "Kavan the Arcanist"
    unit = "party3"
    isPlayer = 1
    unitGuild = nil
    unitRank = nil
    ricon = nil
    color = <table> {
     b = 0.94
     colorStr = "ff69ccf0"
     g = 0.8
     r = 0.41
    }
    line1 = "Kavan the Arcanist"
    alive = true
    level = 90
    cfg = <table> {
     outline = "NONE"
     colorborderItem = true
     point = <table> {
     }
     scale = 1
     cursor = false
     combathide = false
     boss = "??"
     fontsize = 12
     auraCaster = true
     auraID = true
     showRank = false
     hideHealthbar = true
     combathideALL = false
     powerbar = false
     powerManaOnly = true
     hideTitles = false
     multiTip = false
     backdrop = <table> {
     }
     hidePvP = true
     hideRealm = false
     gcolor = <table> {
     }
     font = "Fonts\FRIZQT__.TTF"
     you = "<You>"
     bdrcolor = <table> {
     }
     tex = "Interface\Buttons\WHITE8x8"
     hideFaction = true
     bgcolor = <table> {
     }
     colorborderClass = false
    }
    InCombatLockdown = <function> defined =[C]:-1
    hideLines = <function> defined @Interface\AddOns\FreebTip\tip.lua:176
    PlayerTitle = <function> defined @Interface\AddOns\FreebTip\tip.lua:293
    PlayerGuild = <function> defined @Interface\AddOns\FreebTip\tip.lua:318
    ICON_LIST = <table> {
     1 = "|TInterface\TargetingFrame\UI-RaidTargetingIcon_1:"
     2 = "|TInterface\TargetingFrame\UI-RaidTargetingIcon_2:"
     3 = "|TInterface\TargetingFrame\UI-RaidTargetingIcon_3:"
     4 = "|TInterface\TargetingFrame\UI-RaidTargetingIcon_4:"
     5 = "|TInterface\TargetingFrame\UI-RaidTargetingIcon_5:"
     6 = "|TInterface\TargetingFrame\UI-RaidTargetingIcon_6:"
     7 = "|TInterface\TargetingFrame\UI-RaidTargetingIcon_7:"
     8 = "|TInterface\TargetingFrame\UI-RaidTargetingIcon_8:"
    }
    unitColor = <function> defined @Interface\AddOns\FreebTip\tip.lua:126
    hex = <function> defined @Interface\AddOns\FreebTip\tip.lua:119
    GameTooltip_UnitColor = <function> defined @Interface\AddOns\FreebTip\tip.lua:145
    format = <function> defined =[C]:-1
    classification = <table> {
     elite = "+"
     rareelite = " R+"
     rare = " R"
    }
    _G = <table> {
     0 = 1
     ActionButton7FlyoutBorder = ActionButton7FlyoutBorder {
     }
     MultiCastActionButton6Cooldown = MultiCastActionButton6Cooldown {
     }
     MerchantItem9ItemButtonStock = MerchantItem9ItemButtonStock {
     }
     GetTrainerServiceTypeFilter = <function> defined =[C]:-1
     UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names."
     UNIT_NAMEPLATES_TYPE_TOOLTIP_3 = "This method avoids overlapping nameplates by spreading them out horizontally and vertically."
     SetTrainerServiceTypeFilter = <function> defined =[C]:-1
     SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance with you."
     RecruitAFriendFrame = RecruitAFriendFrame {
     }
     CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture = CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture {
     }
     TutorialFrameLeft19 = TutorialFrameLeft19 {
     }
     MultiCastActionButton2Cooldown = MultiCastActionButton2Cooldown {
     }
     ERR_TRADE_EQUIPPED_BAG = "You can't trade equipped bags."
     PVP_RANK_6_1 = "Corporal"
     BOOKTYPE_PROFESSION = "professions"
     AudioOptionsVoicePanelOutputDeviceDropDownButtonHighlightT
    
    Last edited Nov 20, 2013 by Clamsoda
  • Avatar of funkydude funkydude Nov 18, 2013 at 22:52 UTC - 0 likes

    @Clamsoda: Go

    Please post an updated error with the full trace.

    Last edited Nov 18, 2013 by funkydude
  • Avatar of Clamsoda Clamsoda Nov 08, 2013 at 16:16 UTC - 0 likes

    I am using version r198, and I am still plagued by this.

  • Avatar of funkydude funkydude Oct 21, 2013 at 13:24 UTC - 0 likes

    The latest alpha (196) attempts to solve this, however it might do nothing to help.

  • Avatar of Zenzara Zenzara Sep 19, 2013 at 13:56 UTC - 0 likes

    I hope this is fixed soon, it causes huge spikes in my fps and sometimes freezes my game. I've limited it down to this error because when the addon is disabled (along with bugsack) I no longer get the spikes or freezes.

  • 9 comments

Facts

Last updated
Nov 30, 2014
Reported
Oct 22, 2012
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
7

Reported by

Possible assignees