12 - Still missing class colors

In my german client (and I would expect in any other localized client) the class colors are broken. They are always red (r=0.77,g=0.12,b=0.23). I thought it was fixed in http://www.wowace.com/addons/broker_altguild/tickets/8-missing-class-colors/, but the most current version (1.4) still shows this problem for me.

Broker_AltGuild version 1.4
WoW 4.0.1, german client

I fixed it for me with this little hack, but my lua is limited (specially concerning tables...) and I'm sure there are better ways:
I added the folling two lines

for en,loc in pairs(LOCALIZED_CLASS_NAMES_MALE) do if v.Class:upper() == loc:upper() then v.Class = en end end
for en,loc in pairs(LOCALIZED_CLASS_NAMES_FEMALE) do if v.Class:upper() == loc:upper() then v.Class = en end end

right before this line:

local classcolor = RAID_CLASS_COLORS[v.Class:upper()] or {r=0.77, g=0.12 ,b=0.23 }

But I'm sure there must be a better way to access the data in LOCALIZED_CLASS_NAMES_(FE)MALE

User	When	Change
yess	Oct 22, 2010 at 15:07 UTC	Changed status from New to Fixed
jakob42	Oct 20, 2010 at 08:36 UTC	Create

You must login to post a comment. Don't have an account? Register to get one!

2 comments

- Reply
- #2
jakob42 Oct 22, 2010 at 10:41 UTC - 0 likes
Thats what I meant by "better way". :) Thanks, looks much better than mine. I hope it will be integrated so that we don't have to change it every update.

Kleinerelf Oct 22, 2010 at 09:28 UTC - 0 likes

there is an easy fix for this: replace:

local classcolor = RAID_CLASS_COLORS[v.Class:upper()] or {r=0.77, g=0.12 ,b=0.23 }

with:

local classcolor = RAID_CLASS_COLORS[v.NoLocaleClass:upper()] or {r=0.77, g=0.12 ,b=0.23 }

2 comments

Facts

Last updated: Oct 22, 2010
Reported: Oct 20, 2010
Status: Fixed - Developer made requested changes. QA should verify.
Type: Defect - A shortcoming, fault, or imperfection
Priority: Medium - Normal priority.
Votes: 0

Reported by

jakob42

Possible assignees

yess
- Manager
- Author