77 - Wispers from DeadlyBossMods make it though BossBlock module

What steps will reproduce the problem?
1. Raid with people using DBM
2. Get something they think you should know about
3. Receive 8 or 9 wispers telling you what you already got a BigWigs warning about.

What is the expected output? What do you see instead?
Whispers are expected to be blocked when that option is anabled.

What version of the product are you using?
r5824

Do you have an error log of what happened?

Please provide any additional information below.
It appears that Bossblock.lua is only looking for the string "***" to identify incoming automated spam. DBM is currently prefixing whispers with "<DBM>" I'm guessing this is the default setting. It would be good if that could be picked up as well.

eg.
[xxxx] whispers: <DBM> Legion Flame on YOU!

User	When	Change
Rabbit	Sep 25, 2009 at 01:10 UTC	Changed status from Replied to Fixed
yoshimo	Sep 23, 2009 at 14:06 UTC	Changed status from Waiting to Replied
Rabbit	Sep 23, 2009 at 12:46 UTC	Changed status from New to Waiting
graywolfe	Aug 19, 2009 at 21:05 UTC	Create

You must login to post a comment. Don't have an account? Register to get one!

5 comments

- Reply
- #5
gnarfoz Sep 23, 2009 at 14:22 UTC - 0 likes
So you basically want a "we don't mind if any whisper starting with '<DBM>' is categorically blocked, regardless of circumstances, go ahead" (or a "no, don't do it, then" ;p)?

If so, go ahead IMHO.
- Reply
- #4
mojosdojo Sep 23, 2009 at 14:07 UTC - 0 likes
"I haven't seen a whisper from dbm in a long time, so I can't say if that's still happening." ... but anyway, hide them.

Last edited Sep 23, 2009 by mojosdojo
- Reply
- #3
yoshimo Sep 23, 2009 at 14:06 UTC - 0 likes
It doesnt seem to be very likely that DBM includes warnings that are useful AND bw doesn't have yet .

I dont think it will be a problem to just hide them.
- Reply
- #2
Rabbit Sep 23, 2009 at 12:46 UTC - 0 likes
So lots of people are voting, but noone is replying to my comment.
- Reply
- #1
Rabbit Aug 31, 2009 at 09:02 UTC - 0 likes
I guess the only problem I can foresee here is the following:
1. Next raid instance is released by Blizzard.
2. DBM creates a bossmod for a new encounter in there, and BigWigs does NOT have a bossmod for it.
3. Someone in your raid uses DBM and wants to whisper you this warning.
Currently with the other BossBlock features, like the boss emote blocking, we can check if we have a boss module for the current encounter and if we do not, then we don't block it either.

With these whispers, we couldn't do that (well, we could try, but it wouldn't be 100% reliable, and it would require more lines of code than I want to put in there). We either block them all, or we block nothing, since we don't really know the context of any whisper not sent from ourselves.

If you guys don't think this is a problem then I'd be happy to add this in.
Last edited Aug 31, 2009 by Rabbit