BetterQuest

1 - wrong call to LibSink-2.0 API

in BetterQuest\modules\sink\sink.lua line 73 you have the following code:
self:Pour(ERR_QUEST_COMPLETE_S:format(title), core:GetColorFromCompletion(1))

this :Pour function is LibSink-2.0's embedded function which has the following call signature:
Pour(addon, text, r, g, b, font, size, outline, sticky, loc, icon)

The problem is now that core:GetColorFromCompletion(1) has (besides other) the following code to return values:
return unpack(self.db.profile.colors.done

where self.db.profile.colors.done is a table containing 4 values (RGBA) instead of just the expected 3 (RGB). This results in :Pour(...) being called with an unintended value for 'font' which can result in errors.

In my case, using MSBT, it resulted in an error with LibSharedMedia-3.0 due to LibSink-2.0 trying to register a font using the passed name.

Making sure that only three values are returned by core:GetColorFromCompletion(...) should fix that.

User When Change
Kemayo Apr 03, 2009 at 01:16 UTC Changed status from New to Fixed
Elkano Oct 24, 2008 at 11:49 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Last updated
Mar 30, 2012
Reported
Oct 24, 2008
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
2

Reported by

Possible assignees