BankItems

41 - Fix for "Ignore unstackable soulbound items".

When "Ignore unstackable soulbound items" in options is checked addon is not ignoring gear items that have "Soulbound" or "Binds when picked up" text in 4th or 5th line of tooltip.

It may happen when 2nd line of tooltip contains green text like Heroic, Flexible and so on and/or 3rd/4th line contains "Upgrade Level: x/2"

"Ignore unstackable soulbound items" is enabled by default and in that state item counter on some gear is visible and on some gear is not which may be confusing.

To fix above issue inside file BankItems.lua modify function BankItems_AddTooltipData like below (add bolded text):

local secondLine = _G[self:GetName().."TextLeft2"]:GetText()
local thirdLine = _G[self:GetName().."TextLeft3"]:GetText()
local fourthLine = _G[self:GetName().."TextLeft4"]:GetText()
local fifthLine = _G[self:GetName().."TextLeft5"]:GetText()
local itemStack = select(8, GetItemInfo(item))
if itemStack == 1 and (ignoreTooltipsTypes[secondLine] or ignoreTooltipsTypes[thirdLine] or ignoreTooltipsTypes[fourthLine] or ignoreTooltipsTypes[fifthLine]) then
self.BankItemsDone = true

User When Change
Mornadan Jan 06, 2014 at 21:57 UTC Changed description:
  When "Ignore unstackable soulbound items" in options is checked addon is not ignoring gear items that have "Soulbound" or "Binds when picked up" text in 4th or 5th line of tooltip.

- It may happen when 2nd line of tooltip contains green text like Heroic, Flexible and so on and/or 3rd, 4th or 5th line contains "Upgrade Level: x/2"
+ It may happen when 2nd line of tooltip contains green text like Heroic, Flexible and so on and/or 3rd/4th line contains "Upgrade Level: x/2"
  "Ignore unstackable soulbound items" is enabled by default and in that state item counter on some gear is visible and on some gear is not which may be confusing.
  To fix above issue inside file BankItems.lua modify function BankItems_AddTooltipData like below (add bolded text):

- 			local secondLine = _G[self:GetName().."TextLeft2"]:GetText()
+ 			local secondLine = _G[self:GetName().."TextLeft2"]:GetText()\\
-
- 			local thirdLine = _G[self:GetName().."TextLeft3"]:GetText()
+ 			local thirdLine = _G[self:GetName().."TextLeft3"]:GetText()\\
-
- 			**local fourthLine = _G[self:GetName().."TextLeft4"]:GetText()**
+ 			**local fourthLine = _G[self:GetName().."TextLeft4"]:GetText()**\\
-
- 			**local fifthLine = _G[self:GetName().."TextLeft5"]:GetText()**
+ 			**local fifthLine = _G[self:GetName().."TextLeft5"]:GetText()**\\
-
- 			local itemStack = select(8, GetItemInfo(item))
+ 			local itemStack = select(8, GetItemInfo(item))\\
-
- 			if itemStack == 1 and (ignoreTooltipsTypes[secondLine] or ignoreTooltipsTypes[thirdLine] **or ignoreTooltipsTypes[fourthLine] or ignoreTooltipsTypes[fifthLine]**) then
+ 			if itemStack == 1 and (ignoreTooltipsTypes[secondLine] or ignoreTooltipsTypes[thirdLine] **or ignoreTooltipsTypes[fourthLine] or ignoreTooltipsTypes[fifthLine]**) then\\
-
- 				self.BankItemsDone = true
+ 			self.BankItemsDone = true
Mornadan Jan 06, 2014 at 20:57 UTC Changed description:
  To fix above issue inside file BankItems.lua modify function BankItems_AddTooltipData like below (add bolded text):

  			local secondLine = _G[self:GetName().."TextLeft2"]:GetText()
+
  			local thirdLine = _G[self:GetName().."TextLeft3"]:GetText()
+
  			**local fourthLine = _G[self:GetName().."TextLeft4"]:GetText()**
+
  			**local fifthLine = _G[self:GetName().."TextLeft5"]:GetText()**
+
  			local itemStack = select(8, GetItemInfo(item))
+
  			if itemStack == 1 and (ignoreTooltipsTypes[secondLine] or ignoreTooltipsTypes[thirdLine] **or ignoreTooltipsTypes[fourthLine] or ignoreTooltipsTypes[fifthLine]**) then
+
  				self.BankItemsDone = true
Mornadan Jan 06, 2014 at 20:54 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 1 comment
  • Avatar of Mornadan Mornadan Jan 07, 2014 at 10:36 UTC - 0 likes

    Just realized that gear can also has "Transmogrified to: Abc" lines (whole purple text of two lines is treaten like one block) above "Soulbound". In summary "Soulbound" text can show up in tooltip in any line from 2 to 6. It is needed to add one more condition for that.

    Add in proper place

    local sixthLine = _G[self:GetName().."TextLeft6"]:GetText()
    

    and also

    or ignoreTooltipsTypes[fifthLine]
    
  • 1 comment

Facts

Last updated
Jan 06, 2014
Reported
Jan 06, 2014
Status
New - Issue has not had initial review yet.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees