Baggins

22 - Inscription Bag - Missing as container type

What does the provided patch do?

Add Inscription bag to containers

Please provide any additional information below.

Added to \Interface\AddOns\Baggins\Baggins-Filtering.lua in
function Baggins:IsSpecialBag(bag)
Code:

 if SubType == ITEMSUBTYPE["Inscription Bag"] then
  return prefix.."i"
 end

Changes to \Interface\AddOns\Baggins\Baggins-Filtering.lua
Code:

 ["Container"] = {"Bag", "Enchanting Bag", "Engineering Bag", "Herb Bag", "Soul Bag", "Mining Bag", "Leatherworking Bag", "Gem Bag", "Inscription Bag" },

User When Change
mikk Aug 14, 2009 at 04:39 UTC Changed status from New to Fixed
mikk Aug 14, 2009 at 04:39 UTC Changed assigned to from Nargiddley to mikk
Apaseall Jun 19, 2009 at 11:28 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 2 comments
  • Avatar of mikk mikk Aug 14, 2009 at 04:39 UTC - 0 likes

    I've added support for Inscription bags as of r419 (well 421 really since 419-420 spew warnings in non-svn builds).

    It's still in alpha though due to fairly massive rewrites of itemtype translations.

  • Avatar of Phreakazoid Phreakazoid Aug 06, 2009 at 07:08 UTC - 0 likes

    I've tried this, it almost works, except you need to add "Inscription Bag" to the localisation strings too.

    i.e.

    ITEMSUBTYPE["Inscription Bag"] = "Inscription Bag"

    This is added in the same file. Just putting it in default locale is enough to get it to work, but then if it's not added to other languages it will just show up in English.

    After performing the changes in the main text of this ticket, plus adding the localisation string, Inscription Bag filtering is working fine.

  • 2 comments

Facts

Last updated
Mar 30, 2012
Reported
Jun 19, 2009
Status
Fixed - Developer made requested changes. QA should verify.
Type
Defect - A shortcoming, fault, or imperfection
Priority
Medium - Normal priority.
Votes
1

Reported by

Possible assignees