Auracle (De)Buff Monitor

12 - How to test for temp weapon enchant?

Love this addon. Is there a way to test for a temporary weapon enchant?

For my warlock, as an example, I'd like to check when I'm in an instance that my firestone is applied. Can't seem to figure it out.

Thanks!

User When Change
taleden Feb 08, 2010 at 19:31 UTC Changed status from Waiting to Fixed
taleden Jan 20, 2010 at 22:19 UTC Changed status from Started to Waiting
taleden Jan 13, 2010 at 20:19 UTC Changed type from Other to Enhancement

Changed status from Accepted to Started
taleden Jul 24, 2009 at 02:19 UTC Changed status from Waiting to Accepted
taleden Jul 24, 2009 at 00:11 UTC Changed status from Accepted to Waiting
taleden Mar 12, 2009 at 01:14 UTC Changed status from New to Accepted
Quaiche Mar 11, 2009 at 21:03 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

  • 10 comments
  • Avatar of taleden taleden Jan 20, 2010 at 22:18 UTC - 0 likes

    Support for weapon buffs is available in v1.2.0: http://static.wowace.com/content/files/411/163/Auracle-1.2.0-beta-1.zip

    Anyone interested in this feature, please let me know how it works for you. Note that it only works for yourself (so, the tracker has to be in a window which watches "player"), and that weapon buff names should omit the rank (so, use "Rockbiter", not "Rockbiter 1").

    Last edited Jan 24, 2010 by taleden
  • Avatar of taleden taleden Jan 06, 2010 at 18:11 UTC - 0 likes

    Thanks, lxsisdzi. I probably won't have time to go over it til the weekend, but that'll be a lot easier to review.

  • Avatar of lxsisdzi lxsisdzi Jan 06, 2010 at 01:22 UTC - 0 likes

    Blast I thought I'd fixed that. Try this.

    Name Size MD5
    lxs.4.patch 12.5 KiB d372d158147e...
  • Avatar of taleden taleden Jan 04, 2010 at 19:44 UTC - 0 likes

    As I said, your conversion of all tabs to spaces accounts for the vast majority of the changes in that patch file, which in turn makes it very difficult for me to see the real changes.

    What diff tool did you use to generate the patch? With the Linux 'diff' command, you could try the -E , -b or -w switches to filter out the irrelevant changes; I presume there is an equivalent on Windows but don't know offhand what it is.

  • Avatar of lxsisdzi lxsisdzi Jan 04, 2010 at 16:16 UTC - 0 likes

    Poke?

  • Avatar of lxsisdzi lxsisdzi Dec 31, 2009 at 12:58 UTC - 0 likes

    Almost done. A few TODOs scattered through and it seems to get mainhand/offhand muddled up, but time for heroics ^^

    Last edited Dec 31, 2009 by lxsisdzi
  • Avatar of taleden taleden Dec 31, 2009 at 02:36 UTC - 0 likes

    I'd love to have a look at this patch and work with you to get it merged, but the whitespace changes make it pretty tedious to dig out what you actually changed. Any chance you could revert your whitespace changes and generate a patch with just your functional changes?

  • Avatar of lxsisdzi lxsisdzi Dec 29, 2009 at 16:28 UTC - 0 likes

    Pretty much cracked it. I still need ways to get icons for non-shaman enchants, fix tooltips and maybe parse the max duration properly.

    I swapped some whitespace in Auracle.lua, if you can't use the patch let me know. You will want to move Auracle:FindEnchants somewhere else in the file. I noticed some @debug changes in the patch you may want to revert.

    I'll stop working on this for a few days or until I get a response, so as not to waste my effort if you decide not to merge.

    Last edited Dec 30, 2009 by lxsisdzi
  • Avatar of taleden taleden Jul 24, 2009 at 02:19 UTC - 0 likes

    If I ever resume active development, this feature is on my list; if someone would like to implement this in the mean time, feel free to post a patch.

  • Avatar of taleden taleden Mar 12, 2009 at 01:13 UTC - 0 likes

    This might take awhile, since weapon buffs aren't available through the API mechanisms that handle other buffs and debuffs.

  • 10 comments

Facts

Last updated
Mar 30, 2012
Reported
Mar 11, 2009
Status
Fixed - Developer made requested changes. QA should verify.
Type
Enhancement - A change which is intended to better the project in some way
Priority
Medium - Normal priority.
Votes
5

Reported by

Possible assignees