12 - How to test for temp weapon enchant?
Love this addon. Is there a way to test for a temporary weapon enchant?
For my warlock, as an example, I'd like to check when I'm in an instance that my firestone is applied. Can't seem to figure it out.
Thanks!
| User | When | Change |
|---|---|---|
| taleden | Mon, 08 Feb 2010 19:31:19 | Changed status from Waiting to Fixed |
| taleden | Wed, 20 Jan 2010 22:19:07 | Changed status from Started to Waiting |
| taleden | Wed, 13 Jan 2010 20:19:49 | Changed type from Other to Enhancement Changed status from Accepted to Started |
| taleden | Fri, 24 Jul 2009 02:19:03 | Changed status from Waiting to Accepted |
| taleden | Fri, 24 Jul 2009 00:11:45 | Changed status from Accepted to Waiting |
| taleden | Thu, 12 Mar 2009 01:14:03 | Changed status from New to Accepted |
| Quaiche | Wed, 11 Mar 2009 21:03:01 | Create |
- 10 comments
- 10 comments
Facts
- Last updated on
- 08 Feb 2010
- Reported on
- 11 Mar 2009
- Status
- Fixed - Developer made requested changes. QA should verify.
- Type
- Enhancement - A change which is intended to better the project in some way
- Priority
- Medium - Normal priority.
Reported by
Possible assignees
-
- Manager
- Author
Votes (Total: +15, Average: +3.0)
-
Votes +3
-
Votes +3
-
Votes +3
-
Votes +3
-
Votes +3
- #10
taleden Wed, 20 Jan 2010 22:18:11Support for weapon buffs is available in v1.2.0: http://static.wowace.com/content/files/411/163/Auracle-1.2.0-beta-1.zip
Anyone interested in this feature, please let me know how it works for you. Note that it only works for yourself (so, the tracker has to be in a window which watches "player"), and that weapon buff names should omit the rank (so, use "Rockbiter", not "Rockbiter 1").
- #9
taleden Wed, 06 Jan 2010 18:11:29Thanks, lxsisdzi. I probably won't have time to go over it til the weekend, but that'll be a lot easier to review.
- #8
lxsisdzi Wed, 06 Jan 2010 01:22:15Blast I thought I'd fixed that. Try this.
- #7
taleden Mon, 04 Jan 2010 19:44:14As I said, your conversion of all tabs to spaces accounts for the vast majority of the changes in that patch file, which in turn makes it very difficult for me to see the real changes.
What diff tool did you use to generate the patch? With the Linux 'diff' command, you could try the -E , -b or -w switches to filter out the irrelevant changes; I presume there is an equivalent on Windows but don't know offhand what it is.
- #6
lxsisdzi Mon, 04 Jan 2010 16:16:16Poke?
- #5
lxsisdzi Thu, 31 Dec 2009 12:58:08Almost done. A few TODOs scattered through and it seems to get mainhand/offhand muddled up, but time for heroics ^^
- #4
taleden Thu, 31 Dec 2009 02:36:41I'd love to have a look at this patch and work with you to get it merged, but the whitespace changes make it pretty tedious to dig out what you actually changed. Any chance you could revert your whitespace changes and generate a patch with just your functional changes?
- #3
lxsisdzi Tue, 29 Dec 2009 16:28:17Pretty much cracked it. I still need ways to get icons for non-shaman enchants, fix tooltips and maybe parse the max duration properly.
I swapped some whitespace in Auracle.lua, if you can't use the patch let me know. You will want to move Auracle:FindEnchants somewhere else in the file. I noticed some @debug changes in the patch you may want to revert.
I'll stop working on this for a few days or until I get a response, so as not to waste my effort if you decide not to merge.
- #2
taleden Fri, 24 Jul 2009 02:19:12If I ever resume active development, this feature is on my list; if someone would like to implement this in the mean time, feel free to post a patch.
- #1
taleden Thu, 12 Mar 2009 01:13:57This might take awhile, since weapon buffs aren't available through the API mechanisms that handle other buffs and debuffs.