Action Bar Saver

3 - fix spellCache instead of avoiding it

What does the provided patch do?

I fixed the spellCache instead of just skipping it like the previous MoP fix did. This is important because some types of abilities, like the mage Teleport flyout, don't restore correctly off spellid. They need the spellCache.

The problem was that the grayed out "offspec" tabs were getting scanned, and since they're scanned later they overwrite the earlier data. And spells in those gray tabs can't be picked up. GetSpellTabInfo() now has a 6th return for "offSpecID". This is 0 normally, and non-zero on the grayed-out tabs. So when it's non-zero, I skip the tab and don't put it in the cache.

User When Change
Shadowed Sep 13, 2012 at 19:56 UTC
Morsker Sep 13, 2012 at 19:34 UTC

Added attachment 0001-fix-spellCache-by-skipping-grayed-out-offspec-tabs.patch

Morsker Sep 13, 2012 at 19:33 UTC Create

You must login to post a comment. Don't have an account? Register to get one!

Facts

Last updated
Sep 13, 2012
Reported
Sep 13, 2012
Status
Fixed - Developer made requested changes. QA should verify.
Type
Patch - Source code patch for review
Priority
Medium - Normal priority.
Votes
0

Reported by

Possible assignees