11 - Use "Master" Sound Channel
What is the enhancement in mind? How should it look and feel?
I'd like the sound previews to use the pre-patch-4.0 functionality where sounds played at full "master" volume, regardless of SFX volume, or if SFX were turned off. Patch 4.0 broke this, but patch 4.0.6 added a way to restore the functionality with an additional argument to PlaySoundFile.
I think it should be fine to make this change universally since it's the way the mod sounds worked for years anyway. But at the least I'd like a setting, so that addons that use the Master sound channel can request config widgets that also use it. That way the config will accurately preview the sound's volume, and avoid confusing the user with the case where the addon plays sounds with SFX off but the config doesn't.
Please provide any additional information below.
It's a 2-line change to SoundWidget.lua.
| User | When | Change |
|---|---|---|
| Morsker | Mar 22, 2011 at 14:26 UTC | Changed description:**What is the enhancement in mind? How should it look and feel?** - I'd like the pre-patch-4.0 functionality where sounds played at full "master" volume, regardless of SFX volume, or if SFX were turned off. Patch 4.0 broke this, but patch 4.0.6 added a way to restore the functionality with an additional argument to PlaySoundFile. + I'd like the sound previews to use the pre-patch-4.0 functionality where sounds played at full "master" volume, regardless of SFX volume, or if SFX were turned off. Patch 4.0 broke this, but patch 4.0.6 added a way to restore the functionality with an additional argument to PlaySoundFile. I think it should be fine to make this change universally since it's the way the mod sounds worked for years anyway. But at the least I'd like a setting, so that addons that use the Master sound channel can request config widgets that also use it. That way the config will accurately preview the sound's volume, and avoid confusing the user with the case where the addon plays sounds with SFX off but the config doesn't. |
| Morsker | Mar 22, 2011 at 07:51 UTC | Create |
